mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] wait_for_helper: remove unneeded do_sigaction()
@ 2007-04-13  7:28 Oleg Nesterov
  0 siblings, 0 replies; only message in thread
From: Oleg Nesterov @ 2007-04-13  7:28 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Rusty Russell, linux-kernel

allow_signal(SIGCHLD) does all necessary job, no need to call do_sigaction()
prior to.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>

--- 2.6.21-rc5/kernel/kmod.c~WH	2007-04-05 12:18:28.000000000 +0400
+++ 2.6.21-rc5/kernel/kmod.c	2007-04-13 11:14:00.000000000 +0400
@@ -181,14 +181,9 @@ static int wait_for_helper(void *data)
 {
 	struct subprocess_info *sub_info = data;
 	pid_t pid;
-	struct k_sigaction sa;
 
 	/* Install a handler: if SIGCLD isn't handled sys_wait4 won't
 	 * populate the status, but will return -ECHILD. */
-	sa.sa.sa_handler = SIG_IGN;
-	sa.sa.sa_flags = 0;
-	siginitset(&sa.sa.sa_mask, sigmask(SIGCHLD));
-	do_sigaction(SIGCHLD, &sa, NULL);
 	allow_signal(SIGCHLD);
 
 	pid = kernel_thread(____call_usermodehelper, sub_info, SIGCHLD);


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-04-13  7:28 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-04-13  7:28 [PATCH] wait_for_helper: remove unneeded do_sigaction() Oleg Nesterov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®