* Re: [PATCH] lockdep: lookup_chain_cache comment errata
2007-04-19 9:34 [PATCH] lockdep: lookup_chain_cache comment errata Jarek Poplawski
@ 2007-04-19 9:30 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2007-04-19 9:30 UTC (permalink / raw)
To: Jarek Poplawski; +Cc: linux-kernel, Andrew Morton
* Jarek Poplawski <jarkao2@o2.pl> wrote:
> [PATCH] lockdep: lookup_chain_cache comment errata
>
> Signed-off-by: Jarek Poplawski <jarkao2@o2.pl>
thanks,
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] lockdep: lookup_chain_cache comment errata
@ 2007-04-19 9:34 Jarek Poplawski
2007-04-19 9:30 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Jarek Poplawski @ 2007-04-19 9:34 UTC (permalink / raw)
To: linux-kernel; +Cc: Ingo Molnar
[PATCH] lockdep: lookup_chain_cache comment errata
Signed-off-by: Jarek Poplawski <jarkao2@o2.pl>
---
diff -Nurp 2.6.21-rc7-/kernel/lockdep.c 2.6.21-rc7/kernel/lockdep.c
--- 2.6.21-rc7-/kernel/lockdep.c 2007-04-18 10:14:06.000000000 +0200
+++ 2.6.21-rc7/kernel/lockdep.c 2007-04-19 11:25:40.000000000 +0200
@@ -1313,8 +1313,9 @@ out_unlock_set:
/*
* Look up a dependency chain. If the key is not present yet then
- * add it and return 0 - in this case the new dependency chain is
- * validated. If the key is already hashed, return 1.
+ * add it and return 1 - in this case the new dependency chain is
+ * validated. If the key is already hashed, return 0.
+ * (On return with 1 graph_lock is held.)
*/
static inline int lookup_chain_cache(u64 chain_key, struct lock_class *class)
{
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-04-19 9:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-04-19 9:34 [PATCH] lockdep: lookup_chain_cache comment errata Jarek Poplawski
2007-04-19 9:30 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®