From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
<linux-kernel@vger.kernel.org>,
Jan "Yenya" Kasprzak <kas@fi.muni.cz>
Subject: Re: [PATCH 1/3] Char: mxser_new, fix recursive locking
Date: Fri, 20 Apr 2007 13:12:10 +0100 [thread overview]
Message-ID: <20070420131210.166fcd40@the-village.bc.nu> (raw)
In-Reply-To: <20225157853131727049@wsc.cz>
> Acquire a port lock only if not in_interrupt in some places, because ISR
> holds the lock yet (and ldisc calls some of driver's routines which tries to
> acquire it again due to tty->low_latency).
NAK
This is the wrong way to do it. If you don't support recursive entry then
don't use ->low_latency. If you do then ensure you drop the lock before
you call tty_flip_buffer_push().
The other way this could be tackled which has some merit is to require
that line discipline responses coming from a received frame call a new
tty method so drivers can tell callbacks from arriving data apart from
other events.
Alan
next prev parent reply other threads:[~2007-04-20 12:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-20 10:34 Jiri Slaby
2007-04-20 10:35 ` [PATCH 2/3] Char: mxser_new, fix TIOCMIWAIT Jiri Slaby
2007-04-20 14:12 ` Jan Yenya Kasprzak
2007-04-20 10:36 ` [PATCH 3/3] Char: mxser, " Jiri Slaby
2007-04-20 12:12 ` Alan Cox [this message]
2007-04-20 14:15 ` [PATCH 1/3] Char: mxser_new, fix recursive locking Jan Yenya Kasprzak
2007-04-20 14:18 ` Jiri Slaby
2007-04-20 15:29 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070420131210.166fcd40@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=jirislaby@gmail.com \
--cc=kas@fi.muni.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®