From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jan Yenya Kasprzak <kas@fi.muni.cz>
Cc: Jiri Slaby <jirislaby@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Char: mxser_new, fix recursive locking
Date: Fri, 20 Apr 2007 16:29:31 +0100 [thread overview]
Message-ID: <20070420162931.44f426e9@the-village.bc.nu> (raw)
In-Reply-To: <20070420141551.GQ22955@fi.muni.cz>
> Signed-off-by: Jan "Yenya" Kasprzak <kas@fi.muni.cz>
> Cc: Jiri Slaby <jirislaby@gmail.com>
> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Acked-by: Alan Cox <alan@redhat.com>
>
> --- linux-2.6.21-rc2/drivers/char/mxser_new.c.orig 2007-04-20 15:41:46.000000000 +0200
> +++ linux-2.6.21-rc2/drivers/char/mxser_new.c 2007-04-20 15:46:46.000000000 +0200
> @@ -2230,7 +2230,14 @@
> port->mon_data.rxcnt += cnt;
> port->mon_data.up_rxcnt += cnt;
>
> + /*
> + * We are called from an interrupt context with &port->slock
> + * being held. Drop it temporarily in order to prevent
> + * recursive locking.
> + */
> + spin_unlock(&port->slock);
> tty_flip_buffer_push(tty);
> + spin_lock(&port->slock);
> }
>
prev parent reply other threads:[~2007-04-20 15:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-20 10:34 Jiri Slaby
2007-04-20 10:35 ` [PATCH 2/3] Char: mxser_new, fix TIOCMIWAIT Jiri Slaby
2007-04-20 14:12 ` Jan Yenya Kasprzak
2007-04-20 10:36 ` [PATCH 3/3] Char: mxser, " Jiri Slaby
2007-04-20 12:12 ` [PATCH 1/3] Char: mxser_new, fix recursive locking Alan Cox
2007-04-20 14:15 ` Jan Yenya Kasprzak
2007-04-20 14:18 ` Jiri Slaby
2007-04-20 15:29 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070420162931.44f426e9@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=jirislaby@gmail.com \
--cc=kas@fi.muni.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®