From: Bastian Blank <bastian@waldi.eu.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Theodore Ts'o" <tytso@mit.edu>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Allow reading tainted flag as user
Date: Sun, 22 Apr 2007 10:58:09 +0200 [thread overview]
Message-ID: <20070422085809.GA9078@wavehammer.waldi.eu.org> (raw)
In-Reply-To: <20070422015045.f39d6ff7.akpm@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 870 bytes --]
On Sun, Apr 22, 2007 at 01:50:45AM -0700, Andrew Morton wrote:
> On Sun, 22 Apr 2007 10:39:41 +0200 Bastian Blank <bastian@waldi.eu.org> wrote:
>
> > The commit 34f5a39899f3f3e815da64f48ddb72942d86c366 restricted reading
> > of the tainted value. The attached patch changes this back to a
> > write-only check and restores the read behaviour of older versions.
> >
> > Signed-off-by: Bastian Blank <bastian@waldi.eu.org>
>
> there's no patch here.
Ups.
diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index 1b255df..c904748 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -1676,7 +1676,7 @@ static int proc_dointvec_taint(ctl_table *table, int write, struct file *filp,
{
int op;
- if (!capable(CAP_SYS_ADMIN))
+ if (write && !capable(CAP_SYS_ADMIN))
return -EPERM;
op = OP_OR;
--
Captain's Log, star date 21:34.5...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2007-04-22 8:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-22 8:39 Bastian Blank
2007-04-22 8:50 ` Andrew Morton
2007-04-22 8:58 ` Bastian Blank [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070422085809.GA9078@wavehammer.waldi.eu.org \
--to=bastian@waldi.eu.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®