[PATCH] Allow reading tainted flag as user

[PATCH] Allow reading tainted flag as user

[Bastian Blank]

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

The commit 34f5a39899f3f3e815da64f48ddb72942d86c366 restricted reading
of the tainted value. The attached patch changes this back to a
write-only check and restores the read behaviour of older versions.

Signed-off-by: Bastian Blank <bastian@waldi.eu.org>

-- 
The joys of love made her human and the agonies of love destroyed her.
		-- Spock, "Requiem for Methuselah", stardate 5842.8

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH] Allow reading tainted flag as user

[Andrew Morton]

On Sun, 22 Apr 2007 10:39:41 +0200 Bastian Blank <bastian@waldi.eu.org> wrote:

> The commit 34f5a39899f3f3e815da64f48ddb72942d86c366 restricted reading
> of the tainted value. The attached patch changes this back to a
> write-only check and restores the read behaviour of older versions.
> 
> Signed-off-by: Bastian Blank <bastian@waldi.eu.org>

there's no patch here.

And I'd be interested to see it, because Ted's patch converted it from 0444
to 0644, which sounds right.

Re: [PATCH] Allow reading tainted flag as user

[Bastian Blank]

[-- Attachment #1: Type: text/plain, Size: 870 bytes --]

On Sun, Apr 22, 2007 at 01:50:45AM -0700, Andrew Morton wrote:
> On Sun, 22 Apr 2007 10:39:41 +0200 Bastian Blank <bastian@waldi.eu.org> wrote:
> 
> > The commit 34f5a39899f3f3e815da64f48ddb72942d86c366 restricted reading
> > of the tainted value. The attached patch changes this back to a
> > write-only check and restores the read behaviour of older versions.
> > 
> > Signed-off-by: Bastian Blank <bastian@waldi.eu.org>
> 
> there's no patch here.

Ups.

diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index 1b255df..c904748 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -1676,7 +1676,7 @@ static int proc_dointvec_taint(ctl_table *table, int write, struct file *filp,
 {
 	int op;
 
-	if (!capable(CAP_SYS_ADMIN))
+	if (write && !capable(CAP_SYS_ADMIN))
 		return -EPERM;
 
 	op = OP_OR;

-- 
Captain's Log, star date 21:34.5...

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]