Re: [PATCH 2/2] x86_64: Remove CONFIG_PHYSICAL_START and CONFIG_RELOCATABLE

[Vivek Goyal <vgoyal@in.ibm.com>]

On Mon, Apr 23, 2007 at 12:17:22AM -0600, Eric W. Biederman wrote:
> Vivek Goyal <vgoyal@in.ibm.com> writes:
> 
> > On Sun, Apr 22, 2007 at 11:15:48PM -0600, Eric W. Biederman wrote:
> >> +++ b/arch/x86_64/Kconfig
> >> @@ -565,62 +565,9 @@ config CRASH_DUMP
> >>            which are loaded in the main kernel with kexec-tools into
> >>            a specially reserved region and then later executed after
> >>            a crash by kdump/kexec. The crash dump kernel must be compiled
> >> -	  to a memory address not used by the main kernel or BIOS using
> >> -	  PHYSICAL_START.
> >> +	  to a memory address not used by the main kernel or BIOS
> >>            For more details see Documentation/kdump/kdump.txt
> >
> > Hi Eric,
> >
> > I think "must be compiled" should be replaced with "must be loaded" now.
> 
> Yes, that sounds right.  Ugh.  I didn't look at enough context to read
> the whole sentence.  I just killed the part about PHYSICAL_START.
> 
> > Otherwise both the patches look fine.  I am planning to test these.
> >
> > This change will also require modifications to Documentation/kdump/kdump.txt
> > file.
> 
> Do you think you can generate the patch fix up the CONFIG_CRASH_DUMP
> and kdump.txt documentation.
> 

Ok. I will send one.

Thanks
Vivek