* (no subject)
@ 2007-04-30 22:06 Corey Minyard
0 siblings, 0 replies; only message in thread
From: Corey Minyard @ 2007-04-30 22:06 UTC (permalink / raw)
To: Linux Kernel, Russell King; +Cc: linux-serial
I think I've spotted a bug in the 8250 code, but I'm not really
sure. I'm having a hard time understanding why the lsr_break_flag
is necessary.
Subject: Serial 8250: clear the lsr_break_flag at open
The lsr_break_flag in the 8250 driver is not cleared when the port is
opened. This means that on a serial console, if a break has occurred
while the port is closed, the first call to receive_chars() will
result in a break being delivered at that point. Clear the flag at
open to fix the problem.
Signed-off-by: Corey Minyard <minyard@acm.org>
Index: linux-2.6.21/drivers/serial/8250.c
===================================================================
--- linux-2.6.21.orig/drivers/serial/8250.c
+++ linux-2.6.21/drivers/serial/8250.c
@@ -1638,6 +1638,7 @@ static int serial8250_startup(struct uar
up->capabilities = uart_config[up->port.type].flags;
up->mcr = 0;
+ up->lsr_break_flag = 0;
if (up->port.type == PORT_16C950) {
/* Wake up and initialize UART */
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-04-30 22:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-04-30 22:06 Corey Minyard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®