* [2.6.22 PATCH 25/26] dm raid1: switch rh_in_sync to blocking in do_reads
@ 2007-05-08 19:49 Alasdair G Kergon
0 siblings, 0 replies; only message in thread
From: Alasdair G Kergon @ 2007-05-08 19:49 UTC (permalink / raw)
To: Andrew Morton; +Cc: dm-devel, linux-kernel, Jonathan Brassow
From: Jonathan Brassow <jbrassow@redhat.com>
The call to rh_in_sync() in do_reads() should be allowed to block. It
is in the mirror worker thread which already permits blocking
operations. This will be needed to support clustered mirroring which
will perform network operations.
Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
---
drivers/md/dm-raid1.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.21/drivers/md/dm-raid1.c
===================================================================
--- linux-2.6.21.orig/drivers/md/dm-raid1.c 2007-05-01 19:20:17.000000000 +0100
+++ linux-2.6.21/drivers/md/dm-raid1.c 2007-05-01 19:20:19.000000000 +0100
@@ -741,7 +741,7 @@ static void do_reads(struct mirror_set *
/*
* We can only read balance if the region is in sync.
*/
- if (rh_in_sync(&ms->rh, region, 0))
+ if (rh_in_sync(&ms->rh, region, 1))
m = choose_mirror(ms, bio->bi_sector);
else
m = ms->default_mirror;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-05-08 19:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-05-08 19:49 [2.6.22 PATCH 25/26] dm raid1: switch rh_in_sync to blocking in do_reads Alasdair G Kergon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®