mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH]x86_64: early_print kernel console should send CRLF not LFCR
@ 2007-05-17  2:19 Yinghai Lu
  0 siblings, 0 replies; only message in thread
From: Yinghai Lu @ 2007-05-17  2:19 UTC (permalink / raw)
  To: Andi Kleen, Andrew Morton, rmk; +Cc: Linux Kernel Mailing List, Yinghai.Lu

[PATCH]x86_64: early_print kernel console should send CRLF not LFCR

   in 
	commit d358788f3f30113e49882187d794832905e42592
	Author: Russell King <rmk@dyn-67.arm.linux.org.uk>
	Date:   Mon Mar 20 20:00:09 2006 +0000

    Glen Turner reported that writing LFCR rather than the more
    traditional CRLF causes issues with some terminals.

    Since this aflicts many serial drivers, extract the common code
    to a library function (uart_console_write) and arrange for each
    driver to supply a "putchar" function.

    but early_printk is left out. 

    Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>
    Cc: Andi Kleen <ak@suse.de>
    Cc: Russell King <rmk@arm.linux.org.uk>

diff --git a/arch/x86_64/kernel/early_printk.c b/arch/x86_64/kernel/early_printk.c
index 56eaa25..296d2b0 100644
--- a/arch/x86_64/kernel/early_printk.c
+++ b/arch/x86_64/kernel/early_printk.c
@@ -91,9 +91,9 @@ static int early_serial_putc(unsigned char ch)
 static void early_serial_write(struct console *con, const char *s, unsigned n)
 {
 	while (*s && n-- > 0) {
-		early_serial_putc(*s);
 		if (*s == '\n')
 			early_serial_putc('\r');
+		early_serial_putc(*s);
 		s++;
 	}
 }

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-05-17  2:21 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-05-17  2:19 [PATCH]x86_64: early_print kernel console should send CRLF not LFCR Yinghai Lu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®