* [PATCH] uselib: add missing MNT_NOEXEC check
@ 2007-05-17 13:55 Christoph Hellwig
2007-05-17 16:14 ` Ulrich Drepper
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2007-05-17 13:55 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel
We don't allow loading ELF shared library from noexec points so the
same should apply to sys_uselib aswell.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6/fs/exec.c
===================================================================
--- linux-2.6.orig/fs/exec.c 2007-04-24 14:22:40.000000000 +0200
+++ linux-2.6/fs/exec.c 2007-04-24 14:22:57.000000000 +0200
@@ -133,6 +133,8 @@ asmlinkage long sys_uselib(const char __
goto out;
error = -EINVAL;
+ if (nd.mnt->mnt_flags & MNT_NOEXEC)
+ goto exit;
if (!S_ISREG(nd.dentry->d_inode->i_mode))
goto exit;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] uselib: add missing MNT_NOEXEC check
2007-05-17 13:55 [PATCH] uselib: add missing MNT_NOEXEC check Christoph Hellwig
@ 2007-05-17 16:14 ` Ulrich Drepper
2007-05-17 18:44 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Ulrich Drepper @ 2007-05-17 16:14 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: akpm, linux-kernel
On 5/17/07, Christoph Hellwig <hch@lst.de> wrote:
> We don't allow loading ELF shared library from noexec points so the
> same should apply to sys_uselib aswell.
Correct. But...
> error = -EINVAL;
> + if (nd.mnt->mnt_flags & MNT_NOEXEC)
> + goto exit;
... the error here should be EACCES. Aside from that you get an ACK from me.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] uselib: add missing MNT_NOEXEC check
2007-05-17 16:14 ` Ulrich Drepper
@ 2007-05-17 18:44 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2007-05-17 18:44 UTC (permalink / raw)
To: Ulrich Drepper; +Cc: Christoph Hellwig, akpm, linux-kernel
On Thu, May 17, 2007 at 09:14:06AM -0700, Ulrich Drepper wrote:
> > error = -EINVAL;
> >+ if (nd.mnt->mnt_flags & MNT_NOEXEC)
> >+ goto exit;
>
> ... the error here should be EACCES. Aside from that you get an ACK from
> me.
updated patch below:
Index: linux-2.6/fs/exec.c
===================================================================
--- linux-2.6.orig/fs/exec.c 2007-05-17 14:43:25.000000000 +0200
+++ linux-2.6/fs/exec.c 2007-05-17 19:42:49.000000000 +0200
@@ -134,6 +134,9 @@ asmlinkage long sys_uselib(const char __
if (error)
goto out;
+ error = -EACCES;
+ if (nd.mnt->mnt_flags & MNT_NOEXEC)
+ goto exit;
error = -EINVAL;
if (!S_ISREG(nd.dentry->d_inode->i_mode))
goto exit;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-05-17 18:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-05-17 13:55 [PATCH] uselib: add missing MNT_NOEXEC check Christoph Hellwig
2007-05-17 16:14 ` Ulrich Drepper
2007-05-17 18:44 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome