mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Paul Menage <menage@google.com>
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>,
	Paul Jackson <pj@sgi.com>, LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] Fix a simple issue w.r.t mounting of containers
Date: Fri, 18 May 2007 18:09:16 +0530	[thread overview]
Message-ID: <20070518123916.21450.21761.sendpatchset@balbir-laptop> (raw)



Fix containers mounting issue. With the current v9 patches if a container
hierarchy is mounted and then umounted. A second mount of the hierarchy
fails

Steps to reproduce the problem

1. mount -t container container /<mnt point>
2. umount /<mnt point>
3. mount -t container container /<mnt point>

Step 3 fails with -EBUSY. This is due to the fact that when we unmount,
in container_put_super(), we need to delete the current root from the roots
list.

The patch below fixes the issue


Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com>
---

 kernel/container.c |    1 +
 1 file changed, 1 insertion(+)

diff -puN kernel/container.c~fix-remount-issue kernel/container.c
--- linux-2.6.21-mm1/kernel/container.c~fix-remount-issue	2007-05-18 17:59:40.000000000 +0530
+++ linux-2.6.21-mm1-balbir/kernel/container.c	2007-05-18 18:00:02.000000000 +0530
@@ -574,6 +574,7 @@ static void container_put_super(struct s
 	ret = rebind_subsystems(root, 0);
 	BUG_ON(ret);
 
+	list_del(&root->root_list);
 	kfree(root);
 	mutex_unlock(&container_mutex);
 }
_

-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL

             reply	other threads:[~2007-05-18 12:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-18 12:39 Balbir Singh [this message]
2007-05-18 14:37 ` Paul Menage

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070518123916.21450.21761.sendpatchset@balbir-laptop \
    --to=balbir@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menage@google.com \
    --cc=pj@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®