mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1/2] AF_RXRPC: AF_RXRPC depends on IPv4
@ 2007-05-22 12:56 David Howells
  2007-05-22 12:56 ` [PATCH 2/2] AF_RXRPC: Make call state names available if CONFIG_PROC_FS=n David Howells
  2007-05-22 23:13 ` [PATCH 1/2] AF_RXRPC: AF_RXRPC depends on IPv4 David Miller
  0 siblings, 2 replies; 4+ messages in thread
From: David Howells @ 2007-05-22 12:56 UTC (permalink / raw)
  To: akpm; +Cc: linux-kernel, netdeg, dhowells

Add a dependency for CONFIG_AF_RXRPC on CONFIG_INET.  This fixes this error:

net/built-in.o: In function `rxrpc_get_peer':
(.text+0x42824): undefined reference to `ip_route_output_key'

Signed-off-by: David Howells <dhowells@redhat.com>
---

 net/rxrpc/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/rxrpc/Kconfig b/net/rxrpc/Kconfig
index 91b3d52..e662f1d 100644
--- a/net/rxrpc/Kconfig
+++ b/net/rxrpc/Kconfig
@@ -4,7 +4,7 @@
 
 config AF_RXRPC
 	tristate "RxRPC session sockets"
-	depends on EXPERIMENTAL
+	depends on INET && EXPERIMENTAL
 	select KEYS
 	help
 	  Say Y or M here to include support for RxRPC session sockets (just


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] AF_RXRPC: Make call state names available if CONFIG_PROC_FS=n
  2007-05-22 12:56 [PATCH 1/2] AF_RXRPC: AF_RXRPC depends on IPv4 David Howells
@ 2007-05-22 12:56 ` David Howells
  2007-05-22 23:14   ` David Miller
  2007-05-22 23:13 ` [PATCH 1/2] AF_RXRPC: AF_RXRPC depends on IPv4 David Miller
  1 sibling, 1 reply; 4+ messages in thread
From: David Howells @ 2007-05-22 12:56 UTC (permalink / raw)
  To: akpm; +Cc: linux-kernel, netdeg, dhowells

Make the call state names array available even if CONFIG_PROC_FS is disabled
as it's used in other places (such as debugging statements) too.

Signed-off-by: David Howells <dhowells@redhat.com>
---

 net/rxrpc/ar-call.c |   19 +++++++++++++++++++
 net/rxrpc/ar-proc.c |   19 -------------------
 2 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/net/rxrpc/ar-call.c b/net/rxrpc/ar-call.c
index 4d92d88..3c04b00 100644
--- a/net/rxrpc/ar-call.c
+++ b/net/rxrpc/ar-call.c
@@ -15,6 +15,25 @@
 #include <net/af_rxrpc.h>
 #include "ar-internal.h"
 
+const char *rxrpc_call_states[] = {
+	[RXRPC_CALL_CLIENT_SEND_REQUEST]	= "ClSndReq",
+	[RXRPC_CALL_CLIENT_AWAIT_REPLY]		= "ClAwtRpl",
+	[RXRPC_CALL_CLIENT_RECV_REPLY]		= "ClRcvRpl",
+	[RXRPC_CALL_CLIENT_FINAL_ACK]		= "ClFnlACK",
+	[RXRPC_CALL_SERVER_SECURING]		= "SvSecure",
+	[RXRPC_CALL_SERVER_ACCEPTING]		= "SvAccept",
+	[RXRPC_CALL_SERVER_RECV_REQUEST]	= "SvRcvReq",
+	[RXRPC_CALL_SERVER_ACK_REQUEST]		= "SvAckReq",
+	[RXRPC_CALL_SERVER_SEND_REPLY]		= "SvSndRpl",
+	[RXRPC_CALL_SERVER_AWAIT_ACK]		= "SvAwtACK",
+	[RXRPC_CALL_COMPLETE]			= "Complete",
+	[RXRPC_CALL_SERVER_BUSY]		= "SvBusy  ",
+	[RXRPC_CALL_REMOTELY_ABORTED]		= "RmtAbort",
+	[RXRPC_CALL_LOCALLY_ABORTED]		= "LocAbort",
+	[RXRPC_CALL_NETWORK_ERROR]		= "NetError",
+	[RXRPC_CALL_DEAD]			= "Dead    ",
+};
+
 struct kmem_cache *rxrpc_call_jar;
 LIST_HEAD(rxrpc_calls);
 DEFINE_RWLOCK(rxrpc_call_lock);
diff --git a/net/rxrpc/ar-proc.c b/net/rxrpc/ar-proc.c
index 58f4b4e..1c0be0e 100644
--- a/net/rxrpc/ar-proc.c
+++ b/net/rxrpc/ar-proc.c
@@ -25,25 +25,6 @@ static const char *rxrpc_conn_states[] = {
 	[RXRPC_CONN_NETWORK_ERROR]	= "NetError",
 };
 
-const char *rxrpc_call_states[] = {
-	[RXRPC_CALL_CLIENT_SEND_REQUEST]	= "ClSndReq",
-	[RXRPC_CALL_CLIENT_AWAIT_REPLY]		= "ClAwtRpl",
-	[RXRPC_CALL_CLIENT_RECV_REPLY]		= "ClRcvRpl",
-	[RXRPC_CALL_CLIENT_FINAL_ACK]		= "ClFnlACK",
-	[RXRPC_CALL_SERVER_SECURING]		= "SvSecure",
-	[RXRPC_CALL_SERVER_ACCEPTING]		= "SvAccept",
-	[RXRPC_CALL_SERVER_RECV_REQUEST]	= "SvRcvReq",
-	[RXRPC_CALL_SERVER_ACK_REQUEST]		= "SvAckReq",
-	[RXRPC_CALL_SERVER_SEND_REPLY]		= "SvSndRpl",
-	[RXRPC_CALL_SERVER_AWAIT_ACK]		= "SvAwtACK",
-	[RXRPC_CALL_COMPLETE]			= "Complete",
-	[RXRPC_CALL_SERVER_BUSY]		= "SvBusy  ",
-	[RXRPC_CALL_REMOTELY_ABORTED]		= "RmtAbort",
-	[RXRPC_CALL_LOCALLY_ABORTED]		= "LocAbort",
-	[RXRPC_CALL_NETWORK_ERROR]		= "NetError",
-	[RXRPC_CALL_DEAD]			= "Dead    ",
-};
-
 /*
  * generate a list of extant and dead calls in /proc/net/rxrpc_calls
  */


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] AF_RXRPC: AF_RXRPC depends on IPv4
  2007-05-22 12:56 [PATCH 1/2] AF_RXRPC: AF_RXRPC depends on IPv4 David Howells
  2007-05-22 12:56 ` [PATCH 2/2] AF_RXRPC: Make call state names available if CONFIG_PROC_FS=n David Howells
@ 2007-05-22 23:13 ` David Miller
  1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2007-05-22 23:13 UTC (permalink / raw)
  To: dhowells; +Cc: akpm, linux-kernel, netdeg

From: David Howells <dhowells@redhat.com>
Date: Tue, 22 May 2007 13:56:05 +0100

> Add a dependency for CONFIG_AF_RXRPC on CONFIG_INET.  This fixes this error:
> 
> net/built-in.o: In function `rxrpc_get_peer':
> (.text+0x42824): undefined reference to `ip_route_output_key'
> 
> Signed-off-by: David Howells <dhowells@redhat.com>

Applied.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] AF_RXRPC: Make call state names available if CONFIG_PROC_FS=n
  2007-05-22 12:56 ` [PATCH 2/2] AF_RXRPC: Make call state names available if CONFIG_PROC_FS=n David Howells
@ 2007-05-22 23:14   ` David Miller
  0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2007-05-22 23:14 UTC (permalink / raw)
  To: dhowells; +Cc: akpm, linux-kernel, netdeg

From: David Howells <dhowells@redhat.com>
Date: Tue, 22 May 2007 13:56:10 +0100

> Make the call state names array available even if CONFIG_PROC_FS is disabled
> as it's used in other places (such as debugging statements) too.
> 
> Signed-off-by: David Howells <dhowells@redhat.com>

Also applied, thanks David.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-05-22 23:14 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-05-22 12:56 [PATCH 1/2] AF_RXRPC: AF_RXRPC depends on IPv4 David Howells
2007-05-22 12:56 ` [PATCH 2/2] AF_RXRPC: Make call state names available if CONFIG_PROC_FS=n David Howells
2007-05-22 23:14   ` David Miller
2007-05-22 23:13 ` [PATCH 1/2] AF_RXRPC: AF_RXRPC depends on IPv4 David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®