From: Jean Delvare <khali@linux-fr.org>
To: "Pekka Enberg" <penberg@cs.helsinki.fi>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH] tty_io: Use kzalloc
Date: Fri, 25 May 2007 13:43:44 +0200 [thread overview]
Message-ID: <20070525134344.0f93e797@hyperion.delvare> (raw)
In-Reply-To: <84144f020705250345x4faa23f7kc6276017285357e8@mail.gmail.com>
On Fri, 25 May 2007 13:45:58 +0300, Pekka Enberg wrote:
> Hi Jean,
>
> On 5/25/07, Jean Delvare <khali@linux-fr.org> wrote:
> > - ltp = (struct ktermios *) kmalloc(sizeof(struct ktermios),
> > + ltp = (struct ktermios *) kzalloc(sizeof(struct ktermios),
> > GFP_KERNEL);
>
> When doing conversions like this, please drop the redundant casts too.
Good point, sorry for overlooking this. Updated patch follows.
--
Jean Delvare
next prev parent reply other threads:[~2007-05-25 11:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-25 10:42 Jean Delvare
2007-05-25 10:45 ` Pekka Enberg
2007-05-25 11:43 ` Jean Delvare [this message]
2007-05-25 11:45 ` [PATCH v2] " Jean Delvare
2007-05-25 10:46 ` [PATCH] " Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070525134344.0f93e797@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome