From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Junio C Hamano <junkio@cox.net>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
bzolnier@gmail.com, linux-ide@vger.kernel.org,
Dave Jones <davej@redhat.com>
Subject: Re: [PATCH 2/3] Unify dma blacklist in ide-dma.c and libata-core.c
Date: Sat, 26 May 2007 17:59:47 +0100 [thread overview]
Message-ID: <20070526175947.7dffbec5@the-village.bc.nu> (raw)
In-Reply-To: <7vveela1lv.fsf_-_@assigned-by-dhcp.cox.net>
On Mon, 21 May 2007 22:06:36 -0700
Junio C Hamano <junkio@cox.net> wrote:
> This introduces a shared header file that defines the entries
> for two dma blacklists in ide-dma.c and libata-core.c to make it
> easier to keep them in sync.
>
> Signed-off-by: Junio C Hamano <junkio@cox.net>
NAK
This makes stuff so much more ugly its not funny
> ---
>
> * Removes more lines than it adds. I am not proud of the
> DMA_BLACK_LIST macro in ide-dma.c which relies on the
> compiler doing a sane thing for compile time constant
> expression to initialize the list, but that hopefully can be
> fixed in the next patch.
The basic concept is sound but it would be better to make sure
the ATA_HORKAGE macros and struct ata_blacklist_entry as well as all the
blacklist stuff was placed together in one file to avoid the horrors you
are proposing and then used by both driver sets.
next prev parent reply other threads:[~2007-05-26 16:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-21 14:50 Add Seagate STT20000A to DMA blacklist Dave Jones
2007-05-21 16:15 ` Alan Cox
2007-05-21 17:27 ` Dave Jones
2007-05-22 5:01 ` [PATCH] Match DMA blacklist entries between ide-dma.c and libata-core.c Junio C Hamano
2007-05-22 5:06 ` [PATCH 2/3] Unify dma blacklist in " Junio C Hamano
2007-05-26 16:39 ` Bill Davidsen
2007-05-26 16:59 ` Alan Cox [this message]
2007-05-22 5:08 ` [PATCH 3/3] Make ide dma blacklist handling a bit saner Junio C Hamano
2007-05-28 19:41 ` Bartlomiej Zolnierkiewicz
2007-05-28 23:03 ` Junio C Hamano
2007-05-30 22:36 ` Bartlomiej Zolnierkiewicz
2007-05-28 23:10 ` [PATCH 1/3] ide_in_drive_list(): accept NULL as the wildcard for firmware revision Junio C Hamano
2007-05-30 20:43 ` Bartlomiej Zolnierkiewicz
2007-05-28 23:10 ` [PATCH 2/3] mips au1xxx_ide.h: use NULL as firmware-revision wildcard Junio C Hamano
2007-05-30 20:45 ` Bartlomiej Zolnierkiewicz
2007-05-28 23:11 ` [PATCH 3/3] ide_in_drive_list(): "ALL" is not a wildcard anymore Junio C Hamano
2007-05-30 20:47 ` Bartlomiej Zolnierkiewicz
2007-05-24 0:19 ` [PATCH] Match DMA blacklist entries between ide-dma.c and libata-core.c Bartlomiej Zolnierkiewicz
2007-05-24 0:33 ` Add Seagate STT20000A to DMA blacklist Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070526175947.7dffbec5@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=davej@redhat.com \
--cc=junkio@cox.net \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®