mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	linux-ide@vger.kernel.org, Dave Jones <davej@redhat.com>
Subject: [PATCH 3/3] ide_in_drive_list(): "ALL" is not a wildcard anymore.
Date: Mon, 28 May 2007 16:11:15 -0700	[thread overview]
Message-ID: <7vsl9g7dd8.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <200705282141.42507.bzolnier@gmail.com>

This removes the support to treat "ALL" as a wildcard for
firmware revision.  This is made a separate patch, as it will
break out-of-tree ide drivers that feed its own table that uses
"ALL" as the wildcard to ide_in_drive_list().

Signed-off-by: Junio C Hamano <junkio@cox.net>
---

 * This is a respin of earlier "3/3 Make ide dma blacklist handling a bit saner."

 drivers/ide/ide-dma.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/ide/ide-dma.c b/drivers/ide/ide-dma.c
index 230ea12..3107b5e 100644
--- a/drivers/ide/ide-dma.c
+++ b/drivers/ide/ide-dma.c
@@ -148,7 +148,6 @@ int ide_in_drive_list(struct hd_driveid *id, const struct drive_list_entry *driv
 	for ( ; drive_table->id_model ; drive_table++)
 		if ((!strcmp(drive_table->id_model, id->model)) &&
 		    (!drive_table->id_firmware ||
-		     !strcmp(drive_table->id_firmware, "ALL") || /* to be removed later */
 		     strstr(id->fw_rev, drive_table->id_firmware)))
 			return 1;
 	return 0;
-- 
1.5.2.86.g99b5-dirty



  parent reply	other threads:[~2007-05-28 23:11 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-21 14:50 Add Seagate STT20000A to DMA blacklist Dave Jones
2007-05-21 16:15 ` Alan Cox
2007-05-21 17:27   ` Dave Jones
2007-05-22  5:01   ` [PATCH] Match DMA blacklist entries between ide-dma.c and libata-core.c Junio C Hamano
2007-05-22  5:06     ` [PATCH 2/3] Unify dma blacklist in " Junio C Hamano
2007-05-26 16:39       ` Bill Davidsen
2007-05-26 16:59       ` Alan Cox
2007-05-22  5:08     ` [PATCH 3/3] Make ide dma blacklist handling a bit saner Junio C Hamano
2007-05-28 19:41       ` Bartlomiej Zolnierkiewicz
2007-05-28 23:03         ` Junio C Hamano
2007-05-30 22:36           ` Bartlomiej Zolnierkiewicz
2007-05-28 23:10         ` [PATCH 1/3] ide_in_drive_list(): accept NULL as the wildcard for firmware revision Junio C Hamano
2007-05-30 20:43           ` Bartlomiej Zolnierkiewicz
2007-05-28 23:10         ` [PATCH 2/3] mips au1xxx_ide.h: use NULL as firmware-revision wildcard Junio C Hamano
2007-05-30 20:45           ` Bartlomiej Zolnierkiewicz
2007-05-28 23:11         ` Junio C Hamano [this message]
2007-05-30 20:47           ` [PATCH 3/3] ide_in_drive_list(): "ALL" is not a wildcard anymore Bartlomiej Zolnierkiewicz
2007-05-24  0:19     ` [PATCH] Match DMA blacklist entries between ide-dma.c and libata-core.c Bartlomiej Zolnierkiewicz
2007-05-24  0:33 ` Add Seagate STT20000A to DMA blacklist Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vsl9g7dd8.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bzolnier@gmail.com \
    --cc=davej@redhat.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®