* [PATCH](memory hotplug) Fix unnecessary calling of init_currenty_empty_zone()
@ 2007-05-29 9:47 Yasunori Goto
0 siblings, 0 replies; only message in thread
From: Yasunori Goto @ 2007-05-29 9:47 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-mm, Linux Kernel ML
Hello.
This patch is to fix unnecessary calling of init_currently_empty_zone().
zone->present_pages is updated in online_pages(). But,
__add_zone() can be called twice or more before calling online_pages().
So, init_currenty_empty_zone() can be called unnecessary times.
It is cause of memory leak of zone's wait_table.
This patch is tested on my ia64 box with 2.6.22-rc2-mm1.
Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>
mm/memory_hotplug.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Index: vmemmap/mm/memory_hotplug.c
===================================================================
--- vmemmap.orig/mm/memory_hotplug.c 2007-05-29 15:30:28.000000000 +0900
+++ vmemmap/mm/memory_hotplug.c 2007-05-29 17:31:43.000000000 +0900
@@ -65,7 +65,7 @@ static int __add_zone(struct zone *zone,
int zone_type;
zone_type = zone - pgdat->node_zones;
- if (!populated_zone(zone)) {
+ if (!zone->wait_table) {
int ret = 0;
ret = init_currently_empty_zone(zone, phys_start_pfn,
nr_pages, MEMMAP_HOTPLUG);
--
Yasunori Goto
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-05-29 9:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-05-29 9:47 [PATCH](memory hotplug) Fix unnecessary calling of init_currenty_empty_zone() Yasunori Goto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®