2.6.22-rc3: regression: make M=$PWD modules_install does nothing

2.6.22-rc3: regression: make M=$PWD modules_install does nothing

[Andrey Borzenkov]

[-- Attachment #1: Type: text/plain, Size: 2019 bytes --]

This has been working up and including -rc2:

{pts/1}% sudo make -C ~/src/linux-git O=$HOME/build/linux-2.6.22 M=PWD V=1 
modules_install
make: Entering directory `/home/bor/src/linux-git'
make -C /home/bor/build/linux-2.6.22 \
        KBUILD_SRC=/home/bor/src/linux-git \
        KBUILD_EXTMOD="PWD" -f /home/bor/src/linux-git/Makefile 
modules_install
test -e include/linux/autoconf.h -a -e include/config/auto.conf || (           
\
        echo;                                                           \
        echo "  ERROR: Kernel configuration is invalid.";               \
        echo "         include/linux/autoconf.h or include/config/auto.conf 
are missing.";      \
        echo "         Run 'make oldconfig && make prepare' on kernel src to 
fix it.";  \
        echo;                                                           \
        /bin/false)
mkdir -p /lib/modules/2.6.22-rc3-1avb/extra
make -f /home/bor/src/linux-git/scripts/Makefile.modinst
  if [ -r System.map -a -x /sbin/depmod ]; then /sbin/depmod -ae -F System.map  
2.6.22-rc3-1avb; fi
make: Leaving directory `/home/bor/src/linux-git'

Makefile is trivial:

{pts/1}% cat Makefile
#
# Makefile for wlags49_cs_xxx
#

EXTRA_CFLAGS 
+= -I$(src) -I$(src)/include -I$(src)/include/hcf -I$(src)/include/wireless \
                -DBUS_PCMCIA -DUSE_UIL -DUSE_OLD_PARMS -DUSE_WPA \
                -DUSE_WEXT -DWVLAN_49 \
#               -DDBG \
#               -DUSE_PROFILE

obj-m           += wlags49_h1_cs.o

wlags49_h1_cs-y := wl_profile.o \
            wl_sysfs.o \
            wl_wext.o \
            wl_priv.o \
            wl_main.o \
            wl_enc.o \
            wl_util.o \
            wl_netdev.o \
            wl_cs.o \
            mmd.o \
            hcfio.o \
            hcf.o \
            dhf.o \
            sta_h1.o \
            ap_h1.o



ifndef src
src = .
endif
foo: foo.c hcf.h dhf.h hcfdef.h sta_h1.c
        $(CC) -o foo $(EXTRA_CFLAGS) foo.c


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: 2.6.22-rc3: regression: make M=$PWD modules_install does nothing

[Sam Ravnborg]

Hi Andrey

> This has been working up and including -rc2:

I have tried to reproduce here - but it just works.
I then took a second look at your excellent bug-report and noticed:
> 
> {pts/1}% sudo make -C ~/src/linux-git O=$HOME/build/linux-2.6.22 M=PWD V=1 

that in this commandline you say M=PWD

> modules_install
> make: Entering directory `/home/bor/src/linux-git'
> make -C /home/bor/build/linux-2.6.22 \
>         KBUILD_SRC=/home/bor/src/linux-git \
>         KBUILD_EXTMOD="PWD" -f /home/bor/src/linux-git/Makefile

which tell kbuild that module is in a directory named 'PWD' as seen in the
assignment to KBUILD_EXTMOD in the above line.

Could it be that you by accident omitted a '$' in front of PWD?
This would then tell kbuild that module are in the directory pointed to by $PWD.

	Sam

Re: 2.6.22-rc3: regression: make M=$PWD modules_install does nothing

[Andrey Borzenkov]

[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]

On Wednesday 30 May 2007, Sam Ravnborg wrote:
> Hi Andrey
>
> > This has been working up and including -rc2:
>
> I have tried to reproduce here - but it just works.
>
> I then took a second look at your excellent bug-report and noticed:
> > {pts/1}% sudo make -C ~/src/linux-git O=$HOME/build/linux-2.6.22 M=PWD
> > V=1
>
> that in this commandline you say M=PWD
>
> > modules_install
> > make: Entering directory `/home/bor/src/linux-git'
> > make -C /home/bor/build/linux-2.6.22 \
> >         KBUILD_SRC=/home/bor/src/linux-git \
> >         KBUILD_EXTMOD="PWD" -f /home/bor/src/linux-git/Makefile
>
> which tell kbuild that module is in a directory named 'PWD' as seen in the
> assignment to KBUILD_EXTMOD in the above line.
>
> Could it be that you by accident omitted a '$' in front of PWD?
> This would then tell kbuild that module are in the directory pointed to by
> $PWD.
>

You are right, I am sorry for false alarm. One should not do these things late 
night.

ashamed ...

-andrey

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]