mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* reduce-size-of-task_struct-on-64-bit-machines.patch removed from -mm tree
       [not found] <200705090244.l492i4kH008542@shell0.pdx.osdl.net>
@ 2007-05-29 21:55 ` Kyle McMartin
  2007-05-30  1:10   ` Kyle McMartin
  0 siblings, 1 reply; 2+ messages in thread
From: Kyle McMartin @ 2007-05-29 21:55 UTC (permalink / raw)
  To: akpm; +Cc: wcohen, linux-arch, linux-kernel, ralf

On Tue, May 08, 2007 at 07:44:04PM -0700, akpm@linux-foundation.org wrote:
> -	unsigned long flags;	/* per process flags, defined below */
> -	unsigned long ptrace;
> +	unsigned int flags;	/* per process flags, defined below */
> +	unsigned int ptrace;
>  

So.

I realize I don't have much right to cry over spilled milk here, seeing
as this has been floating around for, what, four months now?

But seriously, if people are going to fuck around with extremely core
pieces of generic code, could they please check all the users[1]?

Other 64-bit arch maintainers should check that they're using a 32-bit
load/store on these fields in their assembly now (we were using a
#define to do word on 32bit and doubleword on 64bit, which broke, badly,
when these changed.)

Thanks,
	Kyle M.

1: Adding __deprecated or something to the field would give you an idea
of where it is used, in this case asm-offsets.c...

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: reduce-size-of-task_struct-on-64-bit-machines.patch removed from -mm tree
  2007-05-29 21:55 ` reduce-size-of-task_struct-on-64-bit-machines.patch removed from -mm tree Kyle McMartin
@ 2007-05-30  1:10   ` Kyle McMartin
  0 siblings, 0 replies; 2+ messages in thread
From: Kyle McMartin @ 2007-05-30  1:10 UTC (permalink / raw)
  To: akpm; +Cc: wcohen, linux-arch, linux-kernel, ralf

On Tue, May 29, 2007 at 05:55:01PM -0400, Kyle McMartin wrote:
> Other 64-bit arch maintainers should check that they're using a 32-bit
> load/store on these fields in their assembly now (we were using a
> #define to do word on 32bit and doubleword on 64bit, which broke, badly,
> when these changed.)
> 

Bummer, I just audited everyone else and we're the only people who use
these flags in assembly. Sigh.

Oh well.

Cheers,
	Kyle

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-05-30  1:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <200705090244.l492i4kH008542@shell0.pdx.osdl.net>
2007-05-29 21:55 ` reduce-size-of-task_struct-on-64-bit-machines.patch removed from -mm tree Kyle McMartin
2007-05-30  1:10   ` Kyle McMartin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®