multiple xor_block() functions

multiple xor_block() functions

[Adrian Bunk]

include/linux/raid/xor.h:extern void xor_block(unsigned int count, unsigned int bytes, void **ptr);
drivers/md/xor.c:xor_block(unsigned int count, unsigned int bytes, void **ptr)
drivers/md/xor.c:EXPORT_SYMBOL(xor_block);

and

net/ieee80211/ieee80211_crypt_ccmp.c:static inline void xor_block(u8 * b, u8 * a, size_t len)


At least one of them has to be renamed.


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: multiple xor_block() functions

[Jouni Malinen]

On Sat, Jun 02, 2007 at 08:57:46PM +0200, Adrian Bunk wrote:
> include/linux/raid/xor.h:extern void xor_block(unsigned int count, unsigned int bytes, void **ptr);
> drivers/md/xor.c:xor_block(unsigned int count, unsigned int bytes, void **ptr)
> drivers/md/xor.c:EXPORT_SYMBOL(xor_block);
> 
> and
> 
> net/ieee80211/ieee80211_crypt_ccmp.c:static inline void xor_block(u8 * b, u8 * a, size_t len)
> 
> 
> At least one of them has to be renamed.

Why? Not that I would really mind renaming one of these, but I don't see
a good reason for it. ieee80211_crypt_ccmp.c should not include
linux/raid/xor.h and the xor_block() in CCMP code is a static inline
function that should not show up outside the scope of this file. Do we
have some magic that makes exported symbols pollute name space for
inlined helper functions?

-- 
Jouni Malinen                                            PGP id EFC895FA

RE: multiple xor_block() functions

[Williams, Dan J]

> From: Adrian Bunk [mailto:bunk@stusta.de]
> include/linux/raid/xor.h:extern void xor_block(unsigned int count,
unsigned
> int bytes, void **ptr);
> drivers/md/xor.c:xor_block(unsigned int count, unsigned int bytes,
void **ptr)
> drivers/md/xor.c:EXPORT_SYMBOL(xor_block);
> 
> and
> 
> net/ieee80211/ieee80211_crypt_ccmp.c:static inline void xor_block(u8 *
b, u8 *
> a, size_t len)
> 
> 
> At least one of them has to be renamed.
> 
I'll rename the raid version to 'xor_blocks' in the md-accel series.  [
I would have suggested xor_n_blocks except that xor_blocks is limited to
5-blocks (MAX_XOR_BLOCKS) ]

> 
> cu
> Adrian
> 

Dan