mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] fix section mismatch warning in initel_cacheinfo
@ 2007-06-02 21:38 Sam Ravnborg
  0 siblings, 0 replies; only message in thread
From: Sam Ravnborg @ 2007-06-02 21:38 UTC (permalink / raw)
  To: Andi Kleen, Andrew Morton, LKML

Fix following warning:
WARNING: arch/i386/kernel/built-in.o(.init.text+0x3818): Section mismatch: reference to .exit.text:cache_remove_dev (between 'cacheinfo_cpu_callback' and 'cache_sysfs_init')

It points out that a function marked __cpuexit is calling
a function marked __cpuinit => oops.
The call happens only in an error-condition which may explain
why we have not seen it before.
The offending function was not used anywhere else - so
marked it __cpuexit.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---

Note: This warning triggers only with a local copy of modpost
      but that version will soon be pushed out.

	Sam

diff --git a/arch/i386/kernel/cpu/intel_cacheinfo.c b/arch/i386/kernel/cpu/intel_cacheinfo.c
index e5be819..0617bb3 100644
--- a/arch/i386/kernel/cpu/intel_cacheinfo.c
+++ b/arch/i386/kernel/cpu/intel_cacheinfo.c
@@ -710,7 +710,7 @@ static int __cpuinit cache_add_dev(struct sys_device * sys_dev)
 	return retval;
 }
 
-static void __cpuexit cache_remove_dev(struct sys_device * sys_dev)
+static void __cpuinit cache_remove_dev(struct sys_device * sys_dev)
 {
 	unsigned int cpu = sys_dev->id;
 	unsigned long i;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-06-02 21:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-06-02 21:38 [PATCH] fix section mismatch warning in initel_cacheinfo Sam Ravnborg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®