From: Randy Dunlap <rdunlap@xenotime.net>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: LKML <linux-kernel@vger.kernel.org>,
rdunlap@xenotime.net, akpm@linux-foundation.org,
Chen Li-jun <cljun@xiyou.edu.cn>,
Wang Ya-gang <lazy_linux@126.com>
Subject: Re: [RFC] Documentation/CodingStyle: Add rules for goto labels
Date: Sun, 3 Jun 2007 07:45:52 -0700 [thread overview]
Message-ID: <20070603074552.430c3d02.rdunlap@xenotime.net> (raw)
In-Reply-To: <20070603142939.GW4095@ftp.linux.org.uk>
On Sun, 3 Jun 2007 15:29:39 +0100 Al Viro wrote:
> On Sun, Jun 03, 2007 at 10:24:50PM +0800, WANG Cong wrote:
>
> > +Do care when you use Lindent to indent your code, since it may use spaces
> > +instead of tabs before a goto label and it may also align the label in a
> > +wrong position. A goto label should be aligned in the column that is 8
> > +characters ahead of the statement just below this label. Please fix it manually
> > +if you find Lindent is wrong.
>
> Lindent is wrong, but the style you are advocating is, at the very
> least, not universal. Equally (if not more) common is putting label
> in column 1, period. Regardless of indentation level of the statement
> following it.
ack Al's style.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2007-06-03 14:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-03 14:24 WANG Cong
2007-06-03 14:29 ` Al Viro
2007-06-03 14:45 ` Randy Dunlap [this message]
2007-06-03 15:35 ` Jeff Garzik
2007-06-04 4:58 ` WANG Cong
2007-06-04 6:59 ` Jeremy Fitzhardinge
2007-06-04 7:51 ` WANG Cong
2007-06-04 8:19 ` [RFC] Documentation/CodingStyle: Add rules for goto labels (-v2) WANG Cong
2007-06-04 18:30 ` Sam Ravnborg
2007-06-04 19:02 ` Jeremy Fitzhardinge
2007-06-05 1:37 ` WANG Cong
2007-06-10 2:31 ` Al Viro
2007-06-04 17:27 ` [RFC] Documentation/CodingStyle: Add rules for goto labels H. Peter Anvin
2007-06-04 19:00 ` Jeremy Fitzhardinge
2007-06-04 21:34 ` H. Peter Anvin
2007-06-04 17:27 ` H. Peter Anvin
2007-06-04 17:35 ` Jan Engelhardt
2007-06-04 17:43 ` H. Peter Anvin
2007-06-04 17:54 ` Valdis.Kletnieks
2007-06-04 18:01 ` H. Peter Anvin
2007-06-04 17:57 ` Jeff Garzik
2007-06-05 2:10 ` WANG Cong
2007-06-05 2:12 ` Jeff Garzik
2007-06-05 2:31 ` H. Peter Anvin
2007-06-05 7:44 ` WANG Cong
2007-06-05 9:16 ` Rene Herman
2007-06-06 4:53 ` WANG Cong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070603074552.430c3d02.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=akpm@linux-foundation.org \
--cc=cljun@xiyou.edu.cn \
--cc=lazy_linux@126.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®