From: WANG Cong <xiyou.wangcong@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Jeff Garzik <jeff@garzik.org>,
Jan Engelhardt <jengelh@linux01.gwdg.de>,
Randy Dunlap <rdunlap@xenotime.net>,
Al Viro <viro@ftp.linux.org.uk>,
LKML <linux-kernel@vger.kernel.org>,
akpm@linux-foundation.org
Subject: Re: [RFC] Documentation/CodingStyle: Add rules for goto labels
Date: Tue, 5 Jun 2007 15:44:31 +0800 [thread overview]
Message-ID: <20070605074431.GB2060@localhost.localdomain> (raw)
In-Reply-To: <4664CAFF.2040300@zytor.com>
On Mon, Jun 04, 2007 at 07:31:27PM -0700, H. Peter Anvin wrote:
>Jeff Garzik wrote:
>>>
>>> So, it seems that we can reach an agreement. Any other comments or suggestions?
>>> Or can someone ack/merge this patch?
>>
>> Honestly, I think not reaching an agreement is a good thing.
>>
>> "style" is always ultimately in the eye of the beholder, and reasoned
>> people come up with multiple answers to the same question.
>>
>> Sometimes it's better _not_ to set things in stone. "use your
>> judgement" and "follow the existing style" go a long way.
>>
>
>Indeed. Quite frankly, style guides would be a lot less obnoxious if
>there weren't always people who felt the need to "correct" other
>people's styles. That is usually a rather obnoxious thing to do, at
>least as long as the code is reasonably clean to start out with.
>
I find things about coding style can easily lead to flamewars anywhere.
Maybe this patch is considered harmful as goto statements once were. ;-p
next prev parent reply other threads:[~2007-06-05 7:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-03 14:24 WANG Cong
2007-06-03 14:29 ` Al Viro
2007-06-03 14:45 ` Randy Dunlap
2007-06-03 15:35 ` Jeff Garzik
2007-06-04 4:58 ` WANG Cong
2007-06-04 6:59 ` Jeremy Fitzhardinge
2007-06-04 7:51 ` WANG Cong
2007-06-04 8:19 ` [RFC] Documentation/CodingStyle: Add rules for goto labels (-v2) WANG Cong
2007-06-04 18:30 ` Sam Ravnborg
2007-06-04 19:02 ` Jeremy Fitzhardinge
2007-06-05 1:37 ` WANG Cong
2007-06-10 2:31 ` Al Viro
2007-06-04 17:27 ` [RFC] Documentation/CodingStyle: Add rules for goto labels H. Peter Anvin
2007-06-04 19:00 ` Jeremy Fitzhardinge
2007-06-04 21:34 ` H. Peter Anvin
2007-06-04 17:27 ` H. Peter Anvin
2007-06-04 17:35 ` Jan Engelhardt
2007-06-04 17:43 ` H. Peter Anvin
2007-06-04 17:54 ` Valdis.Kletnieks
2007-06-04 18:01 ` H. Peter Anvin
2007-06-04 17:57 ` Jeff Garzik
2007-06-05 2:10 ` WANG Cong
2007-06-05 2:12 ` Jeff Garzik
2007-06-05 2:31 ` H. Peter Anvin
2007-06-05 7:44 ` WANG Cong [this message]
2007-06-05 9:16 ` Rene Herman
2007-06-06 4:53 ` WANG Cong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070605074431.GB2060@localhost.localdomain \
--to=xiyou.wangcong@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jeff@garzik.org \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®