mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
	Christoph Lameter <clameter@sgi.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, jeremy@goop.org
Subject: Re: SLUB: Return ZERO_SIZE_PTR for kmalloc(0)
Date: Mon, 4 Jun 2007 18:20:25 +0100	[thread overview]
Message-ID: <20070604182025.558a8d10@the-village.bc.nu> (raw)
In-Reply-To: <alpine.LFD.0.98.0706040924070.23741@woody.linux-foundation.org>

> The thing is, why *should* we care about comparing addresses? We'll give 

Because people use it to tell objects apart. All over the kernel we do
things like

	if (inode1 == inode2)

to figure out if they are the same inode. Now inodes are not zero sized
so we are safe there

> the right result (you got many perfectly separate allocations, they're 
> just zero bytes apart, exactly like you asked for!). The fact that C++ has 
> some semantics for it is not a good argument 

Its the usual semantic in languages that use a pointer as an object
handle. C is actually the oddity here, the other languages use it to
avoid aliasing of object handles and the resulting confusion.

Clearly we do need an option to make the kernel explode when misusing
such pointers for debugging whatever the default for other behaviour is.
And on a 64bit box we probably have enough address space to hand out a
few million unique faulting pointers.

  parent reply	other threads:[~2007-06-04 17:15 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-02  1:37 Christoph Lameter
2007-06-02  2:09 ` John Anthony Kazos Jr.
2007-06-02  2:15   ` Christoph Lameter
2007-06-02  2:21     ` John Anthony Kazos Jr.
2007-06-02  2:54 ` Linus Torvalds
2007-06-02  3:06   ` Christoph Lameter
2007-06-02  3:41 ` Andrew Morton
2007-06-02  4:01   ` Christoph Lameter
2007-06-02  4:31     ` Andrew Morton
2007-06-02  4:45       ` Christoph Lameter
2007-06-02  4:54         ` Andrew Morton
2007-06-03 16:17           ` Matt Mackall
2007-06-04 17:59           ` William Lee Irwin III
2007-06-03 16:15         ` Matt Mackall
2007-06-04 14:44           ` Alan Cox
2007-06-04 15:08         ` Pekka Enberg
2007-06-04 16:16           ` Christoph Lameter
2007-06-04 16:22             ` Pekka Enberg
2007-06-04 16:26               ` Linus Torvalds
2007-06-04 16:32                 ` Jeremy Fitzhardinge
2007-06-04 16:37                 ` Pekka Enberg
2007-06-04 16:38                   ` Jeremy Fitzhardinge
2007-06-04 16:43                   ` Roland Dreier
2007-06-04 17:02                     ` Pekka Enberg
2007-06-04 16:48                   ` Linus Torvalds
2007-06-04 18:22                   ` Cyrill Gorcunov
2007-06-04 17:20                 ` Alan Cox [this message]
2007-06-04 17:50                   ` Linus Torvalds
2007-06-04 18:05                     ` William Lee Irwin III
2007-06-04 18:47 ` Linus Torvalds
2007-06-04 19:01   ` Christoph Lameter
2007-06-04 19:13     ` Pekka Enberg
2007-06-04 19:14       ` Christoph Lameter
2007-06-04 19:25         ` Pekka Enberg
2007-06-04 22:39           ` Christoph Lameter
2007-06-04 22:53             ` Andrew Morton
2007-06-04 23:09               ` Christoph Lameter
2007-06-05  5:27                 ` Pekka Enberg
2007-06-05 17:23                   ` Christoph Lameter
2007-06-05  8:50                 ` Rene Herman
2007-06-05 12:07                   ` John Anthony Kazos Jr.
2007-06-05 12:54                     ` Rene Herman
2007-06-05 13:58                       ` John Anthony Kazos Jr.
2007-06-05 14:32                         ` Rene Herman
2007-06-05 19:07                           ` Pekka Enberg
2007-06-05 14:40                       ` Jeremy Fitzhardinge
2007-06-05 14:56                         ` Rene Herman
2007-06-06 21:26                           ` Pavel Machek
2007-06-06 21:58                             ` Rene Herman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070604182025.558a8d10@the-village.bc.nu \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®