* fix oops on cat /dev/snapshot
@ 2007-06-11 12:17 Pavel Machek
2007-06-11 14:36 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Pavel Machek @ 2007-06-11 12:17 UTC (permalink / raw)
To: B.Steinbrink, Rafael J. Wysocki, Andrew Morton, kernel list
What /dev/snapshot is simply cat-ed -- without ioctls used in normal
operation -- it oopses. This one should fix it.
Signed-off-by: Pavel Machek <pavel@suse.cz>
--- clean-mm/kernel/power/user.c 2007-06-09 16:18:12.000000000 +0200
+++ linux-mm/kernel/power/user.c 2007-06-11 14:06:19.000000000 +0200
@@ -99,6 +99,8 @@
ssize_t res;
data = filp->private_data;
+ if (!data->ready)
+ return -EINVAL;
res = snapshot_read_next(&data->handle, count);
if (res > 0) {
if (copy_to_user(buf, data_of(data->handle), res))
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: fix oops on cat /dev/snapshot
2007-06-11 12:17 fix oops on cat /dev/snapshot Pavel Machek
@ 2007-06-11 14:36 ` Rafael J. Wysocki
2007-06-11 14:32 ` Pavel Machek
0 siblings, 1 reply; 3+ messages in thread
From: Rafael J. Wysocki @ 2007-06-11 14:36 UTC (permalink / raw)
To: Pavel Machek; +Cc: B.Steinbrink, Andrew Morton, kernel list
On Monday, 11 June 2007 14:17, Pavel Machek wrote:
> What /dev/snapshot is simply cat-ed -- without ioctls used in normal
> operation -- it oopses. This one should fix it.
>
> Signed-off-by: Pavel Machek <pavel@suse.cz>
>
> --- clean-mm/kernel/power/user.c 2007-06-09 16:18:12.000000000 +0200
> +++ linux-mm/kernel/power/user.c 2007-06-11 14:06:19.000000000 +0200
> @@ -99,6 +99,8 @@
> ssize_t res;
>
> data = filp->private_data;
> + if (!data->ready)
> + return -EINVAL;
I'd like to use -ENODATA here.
> res = snapshot_read_next(&data->handle, count);
> if (res > 0) {
> if (copy_to_user(buf, data_of(data->handle), res))
>
I have a patch for that and I'm going to post it in a while if you don't
mind.
I've already posted it once, here: http://lkml.org/lkml/2007/6/10/146
Greetings,
Rafael
--
"Premature optimization is the root of all evil." - Donald Knuth
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: fix oops on cat /dev/snapshot
2007-06-11 14:36 ` Rafael J. Wysocki
@ 2007-06-11 14:32 ` Pavel Machek
0 siblings, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2007-06-11 14:32 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: B.Steinbrink, Andrew Morton, kernel list
Hi!
> > What /dev/snapshot is simply cat-ed -- without ioctls used in normal
> > operation -- it oopses. This one should fix it.
> >
> > Signed-off-by: Pavel Machek <pavel@suse.cz>
> >
> > --- clean-mm/kernel/power/user.c 2007-06-09 16:18:12.000000000 +0200
> > +++ linux-mm/kernel/power/user.c 2007-06-11 14:06:19.000000000 +0200
> > @@ -99,6 +99,8 @@
> > ssize_t res;
> >
> > data = filp->private_data;
> > + if (!data->ready)
> > + return -EINVAL;
>
> I'd like to use -ENODATA here.
>
> > res = snapshot_read_next(&data->handle, count);
> > if (res > 0) {
> > if (copy_to_user(buf, data_of(data->handle), res))
> >
>
> I have a patch for that and I'm going to post it in a while if you don't
> mind.
>
> I've already posted it once, here: http://lkml.org/lkml/2007/6/10/146
Aha, go ahead, I did not notice that mail.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-06-11 14:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-06-11 12:17 fix oops on cat /dev/snapshot Pavel Machek
2007-06-11 14:36 ` Rafael J. Wysocki
2007-06-11 14:32 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®