From: Oleg Nesterov <oleg@tv-sign.ru>
To: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Roland McGrath <roland@redhat.com>,
linux-kernel@vger.kernel.org
Subject: w1_therm_read_bin: suspicious usage of flush_signals()
Date: Thu, 14 Jun 2007 21:24:39 +0400 [thread overview]
Message-ID: <20070614172439.GA2468@tv-sign.ru> (raw)
drivers/w1/slaves/w1_therm.c:w1_therm_read_bin()
while (tm) {
tm = msleep_interruptible(tm);
if (signal_pending(current))
flush_signals(current);
}
current is user-space task, yes?
this looks just wrong, could you please explain?
Oleg.
next reply other threads:[~2007-06-14 17:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-14 17:24 Oleg Nesterov [this message]
2007-06-15 4:28 ` Evgeniy Polyakov
2007-06-15 5:10 ` Roland McGrath
2007-06-15 5:52 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070614172439.GA2468@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®