From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Roland McGrath <roland@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: w1_therm_read_bin: suspicious usage of flush_signals()
Date: Fri, 15 Jun 2007 08:28:57 +0400 [thread overview]
Message-ID: <20070615042856.GA22786@2ka.mipt.ru> (raw)
In-Reply-To: <20070614172439.GA2468@tv-sign.ru>
On Thu, Jun 14, 2007 at 09:24:39PM +0400, Oleg Nesterov (oleg@tv-sign.ru) wrote:
> drivers/w1/slaves/w1_therm.c:w1_therm_read_bin()
>
> while (tm) {
> tm = msleep_interruptible(tm);
> if (signal_pending(current))
> flush_signals(current);
> }
>
> current is user-space task, yes?
>
> this looks just wrong, could you please explain?
Hi Oleg.
Well, it can be uninterruptible sleep, but why?
It is not allowed to return to userspace until transaction is completed,
so having uninterruptible sleep will result in exactly same lost of
signals.
> Oleg.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2007-06-15 4:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-14 17:24 Oleg Nesterov
2007-06-15 4:28 ` Evgeniy Polyakov [this message]
2007-06-15 5:10 ` Roland McGrath
2007-06-15 5:52 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070615042856.GA22786@2ka.mipt.ru \
--to=johnpol@2ka.mipt.ru \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®