Re: [uml-devel] [PATCH 2/2] UML - Add stack usage monitoring

[Blaisorblade <blaisorblade@yahoo.it>]

[-- Attachment #1: Type: text/plain, Size: 1653 bytes --]

On martedì 19 giugno 2007, Andrew Morton wrote:
> On Tue, 19 Jun 2007 14:42:45 -0400
>
> Jeff Dike <jdike@addtoit.com> wrote:
> > Add a machanism to see how much of a kernel stack is used.  This
> > allocates zeroed stacks and sees where the lowest non-zero byte is on
> > process exit.  It keeps track of the lowest value and logs values as
> > they get lower.
>
> remind us again why the generic code is unsuitable?
>
> > +	for(p = stack; p < end; p++){
> > +		if(*p != 0)
> > +	if(left < lowest_to_date){
>
> Are there any plans to fix UML coding style?
In Italy we say "habits are hard to die"...

In an (unanswered) thread, titled "[RFC] Auto-fixups for CodingStyle against 
major UML violations" from 31/3/2007, also CC'ed to you, Jeff and LKML, I 
published a script (reattached here) which integrates with quilt and kbuild 
to fix all sources for these violations. It is not indent based, consequently 
it does not do any damages that indent would do.

Plus, with just a couple of tiny changes (for substitutions implying the use 
of '^'), it can also be run on unified diffs.

The only problem is just coordinating to run it together on a source tree and 
on the patch set applying on it. Otherwise the patchset manager would get 
hard-to-fix rejects.

In the end: are you interested in this stuff? I'm busy right now but can work 
to apply these changes after this thursday (i.e. tomorrow). I'd need to get 
Jeff's patchset to fix it.

Please let me know.

Bye!
-- 
Inform me of my mistakes, so I can add them to my list!
Paolo Giarrusso, aka Blaisorblade
http://www.user-mode-linux.org/~blaisorblade

[-- Attachment #2: do-src-style-fix --]
[-- Type: application/x-shellscript, Size: 2795 bytes --]