mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] drop obsolete sys_ioctl export
@ 2007-06-21 21:15 Christoph Hellwig
  2007-06-21 21:17 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2007-06-21 21:15 UTC (permalink / raw)
  To: akpm; +Cc: linux-kernel

sys_ioctl was only exported for our first version of compat ioctl
handling.  Now that the whole compat ioctl handling mess is more or
less sorted out there are no more modular users left and we can kill it.

There's one exception and that's sparc64's solaris compat module, but
sparc64 has it's own export predating the generic one by years for that
which this patch leaves untouched.


Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: linux-2.6/fs/ioctl.c
===================================================================
--- linux-2.6.orig/fs/ioctl.c	2007-06-21 22:09:38.000000000 +0200
+++ linux-2.6/fs/ioctl.c	2007-06-21 22:10:39.000000000 +0200
@@ -182,11 +182,3 @@ asmlinkage long sys_ioctl(unsigned int f
  out:
 	return error;
 }
-
-/*
- * Platforms implementing 32 bit compatibility ioctl handlers in
- * modules need this exported
- */
-#ifdef CONFIG_COMPAT
-EXPORT_SYMBOL(sys_ioctl);
-#endif

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] drop obsolete sys_ioctl export
  2007-06-21 21:15 [PATCH] drop obsolete sys_ioctl export Christoph Hellwig
@ 2007-06-21 21:17 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-06-21 21:17 UTC (permalink / raw)
  To: hch; +Cc: akpm, linux-kernel

From: Christoph Hellwig <hch@lst.de>
Date: Thu, 21 Jun 2007 23:15:17 +0200

> sys_ioctl was only exported for our first version of compat ioctl
> handling.  Now that the whole compat ioctl handling mess is more or
> less sorted out there are no more modular users left and we can kill it.
> 
> There's one exception and that's sparc64's solaris compat module, but
> sparc64 has it's own export predating the generic one by years for that
> which this patch leaves untouched.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Acked-by: David S. Miller <davem@davemloft.net>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-06-21 21:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-06-21 21:15 [PATCH] drop obsolete sys_ioctl export Christoph Hellwig
2007-06-21 21:17 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®