* [PATCH] Guard against a potential NULL pointer dereference in old_capi_manufacturer()
@ 2007-06-24 22:34 Jesper Juhl
0 siblings, 0 replies; only message in thread
From: Jesper Juhl @ 2007-06-24 22:34 UTC (permalink / raw)
To: isdn4linux
Cc: Linux Kernel Mailing List, Carsten Paeth, Kai Germaschewski,
Karsten Keil, Kai Germaschewski, Jesper Juhl
In drivers/isdn/capi/kcapi.c::old_capi_manufacturer(), if the call
to get_capi_ctr_by_nr(ldef.contr); in line 823 returns NULL, then
we'll be dereferencing a NULL pointer in the very next line.
(Found by Coverity checker as bug #402)
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
drivers/isdn/capi/kcapi.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/isdn/capi/kcapi.c b/drivers/isdn/capi/kcapi.c
index 3ed34f7..3f9e962 100644
--- a/drivers/isdn/capi/kcapi.c
+++ b/drivers/isdn/capi/kcapi.c
@@ -821,6 +821,8 @@ static int old_capi_manufacturer(unsigned int cmd, void
__user *data)
return -EFAULT;
}
card = get_capi_ctr_by_nr(ldef.contr);
+ if (!card)
+ return -EINVAL;
card = capi_ctr_get(card);
if (!card)
return -ESRCH;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-06-24 22:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-06-24 22:34 [PATCH] Guard against a potential NULL pointer dereference in old_capi_manufacturer() Jesper Juhl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome