mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jeff Mahoney <jeffm@suse.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: [patch] saa7134 fix
Date: Fri, 29 Jun 2007 20:26:51 +0200	[thread overview]
Message-ID: <20070629182651.GA12811@elte.hu> (raw)

the fix in this commit:

| commit 58e78475ec706f93e0cc049449ffd11fbfdadb3e
| Author: Jeff Mahoney <jeffm@suse.com>
| Date:   Wed Jun 27 14:09:58 2007 -0700
|
|    saa7134: fix thread shutdown handling
|
|    This patch changes the test for the thread pid from >= 0 to > 0.

might be incomplete - there's another place where this driver has a
pid >= 0 check. Should this be 'pid > 0' too?

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 drivers/media/video/saa7134/saa7134-tvaudio.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: v/drivers/media/video/saa7134/saa7134-tvaudio.c
===================================================================
--- v.orig/drivers/media/video/saa7134/saa7134-tvaudio.c
+++ v/drivers/media/video/saa7134/saa7134-tvaudio.c
@@ -1020,7 +1020,7 @@ int saa7134_tvaudio_do_scan(struct saa71
 		dprintk("sound IF not in use, skipping scan\n");
 		dev->automute = 0;
 		saa7134_tvaudio_setmute(dev);
-	} else if (dev->thread.pid >= 0) {
+	} else if (dev->thread.pid > 0) {
 		dev->thread.mode = UNSET;
 		dev->thread.scan2++;
 		wake_up_interruptible(&dev->thread.wq);

                 reply	other threads:[~2007-06-29 18:27 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070629182651.GA12811@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=jeffm@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®