mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [patch] saa7134 fix
@ 2007-06-29 18:26 Ingo Molnar
  0 siblings, 0 replies; only message in thread
From: Ingo Molnar @ 2007-06-29 18:26 UTC (permalink / raw)
  To: Jeff Mahoney; +Cc: Andrew Morton, linux-kernel

the fix in this commit:

| commit 58e78475ec706f93e0cc049449ffd11fbfdadb3e
| Author: Jeff Mahoney <jeffm@suse.com>
| Date:   Wed Jun 27 14:09:58 2007 -0700
|
|    saa7134: fix thread shutdown handling
|
|    This patch changes the test for the thread pid from >= 0 to > 0.

might be incomplete - there's another place where this driver has a
pid >= 0 check. Should this be 'pid > 0' too?

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 drivers/media/video/saa7134/saa7134-tvaudio.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: v/drivers/media/video/saa7134/saa7134-tvaudio.c
===================================================================
--- v.orig/drivers/media/video/saa7134/saa7134-tvaudio.c
+++ v/drivers/media/video/saa7134/saa7134-tvaudio.c
@@ -1020,7 +1020,7 @@ int saa7134_tvaudio_do_scan(struct saa71
 		dprintk("sound IF not in use, skipping scan\n");
 		dev->automute = 0;
 		saa7134_tvaudio_setmute(dev);
-	} else if (dev->thread.pid >= 0) {
+	} else if (dev->thread.pid > 0) {
 		dev->thread.mode = UNSET;
 		dev->thread.scan2++;
 		wake_up_interruptible(&dev->thread.wq);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-06-29 18:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-06-29 18:26 [patch] saa7134 fix Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®