Re: Linux 2.6.22-rc7

[Andre Noll <maan@systemlinux.org>]

[-- Attachment #1: Type: text/plain, Size: 1054 bytes --]

On 09:31, Christoph Lameter wrote:

> > Andre, does that simple change fix it for you (move the 
> > "local_irq_enable()" to the end of early_kmem_cache_node_alloc)?
> 
> Yes that should make the lock checker happy since interrupts are disabled 
> when calling add_partial(). local_irq_enable can be called later without a 
> problem. Useless longer interrupt hold off though.

I can confirm that the message disappears if local_irq_enable() is moved
to the end of the function.

> SLUB: Make lockdep happy by not calling add_partial with interrupts 
> enabled during bootstrap
> 
> If we move the local_irq_enable() to the end of the function then
> add_partial() in early_kmem_cache_node_alloc() will be called
> with interrupts disabled like during regular operations.
> 
> Signed-off-by: Christoph Lameter <clameter@sgi.com>

Tested-By: Andre Noll <maan@systemlinux.org>

Thanks for the quick response and the fix, Linus and Christoph.

Andre
-- 
The only person who always got his work done by Friday was Robinson Crusoe

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]