From: Ingo Molnar <mingo@elte.hu>
To: Christoph Lameter <clameter@sgi.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andre Noll <maan@systemlinux.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.6.22-rc7
Date: Tue, 3 Jul 2007 22:19:00 +0200 [thread overview]
Message-ID: <20070703201900.GA6257@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.64.0707031251160.7491@schroedinger.engr.sgi.com>
* Christoph Lameter <clameter@sgi.com> wrote:
> On Tue, 3 Jul 2007, Ingo Molnar wrote:
>
> > yeah. Your change looks good to me. You could add a
> > local_irq_enable_in_hardirq() to the original place, that will map
> > to a local_irq_enable() on non-lockdep kernels and will be a NOP on
> > lockdep kernels. (This is a bit hacky though.)
>
> Then kernels with lockdep would spew out lots of messages later in
> boot because kmem_cache_init disabled interrupts for good.
no, it would/should result in exactly the same kernel image and lockdep
behavior as with your current patch. (but when lockdep is disabled in
the .config then interrupts are enabled earlier on.) Not a big issue,
just noted this possibility.
Ingo
next prev parent reply other threads:[~2007-07-03 20:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-01 21:32 Linus Torvalds
2007-07-03 15:55 ` Andre Noll
2007-07-03 16:17 ` Linus Torvalds
2007-07-03 16:31 ` Christoph Lameter
2007-07-03 16:46 ` Andre Noll
2007-07-03 19:45 ` Ingo Molnar
2007-07-03 19:52 ` Christoph Lameter
2007-07-03 20:19 ` Ingo Molnar [this message]
2007-07-03 16:14 Martin Knoblauch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070703201900.GA6257@elte.hu \
--to=mingo@elte.hu \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maan@systemlinux.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®