mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Dan Aloni <da-x@monatomic.org>
Cc: Linux Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 10/11] drivers/block/rd.c: lower printk severity
Date: Thu, 5 Jul 2007 10:59:42 -0700	[thread overview]
Message-ID: <20070705105942.ec6396fe.randy.dunlap@oracle.com> (raw)
In-Reply-To: <93d7a361198aac1cdb9bbfe556ae60faa40ff36c.1183551645.git.da-x@monatomic.org>

On Wed, 4 Jul 2007 15:30:22 +0300 Dan Aloni wrote:

> Signed-off-by: Dan Aloni <da-x@monatomic.org>
> ---
>  drivers/block/rd.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/block/rd.c b/drivers/block/rd.c
> index a1512da..3b974f8 100644
> --- a/drivers/block/rd.c
> +++ b/drivers/block/rd.c
> @@ -463,9 +463,9 @@ static int __init rd_init(void)
>  	}
>  
>  	/* rd_size is given in kB */
> -	printk("RAMDISK driver initialized: "
> -		"%d RAM disks of %dK size %d blocksize\n",
> -		CONFIG_BLK_DEV_RAM_COUNT, rd_size, rd_blocksize);
> +	printk(KERN_INFO "RAMDISK driver initialized: "
> +	       "%d RAM disks of %dK size %d blocksize\n",
> +	       CONFIG_BLK_DEV_RAM_COUNT, rd_size, rd_blocksize);
>  
>  	return 0;
>  out:
> -- 

Hi Dan,
All of the changes look good to me except for this one.
The change to use 7 spaces to align the strings is unnecessary.

Thanks.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

  reply	other threads:[~2007-07-05 17:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-04 12:27 [PATCH 1/11] arch/x86_64/kernel/aperture.c: " Dan Aloni
2007-07-04 12:28 ` [PATCH 2/11] arch/x86_64/kernel/apic.c: " Dan Aloni
2007-07-04 12:28 ` [PATCH 3/11] arch/x86_64/kernel/e820.c: " Dan Aloni
2007-07-04 12:28 ` [PATCH 4/11] net/ipv4/netfilter/ip_tables.c: " Dan Aloni
2007-07-04 12:28 ` [PATCH 5/11] drivers/char/ipmi/ipmi_poweroff.c: " Dan Aloni
2007-07-04 12:29 ` [PATCH 6/11] drivers/char/ipmi/ipmi_si_intf.c: " Dan Aloni
2007-07-04 12:29 ` [PATCH 7/11] mm/page_alloc.c: " Dan Aloni
2007-07-04 12:29 ` [PATCH 8/11] drivers/acpi/pci_link.c: " Dan Aloni
2007-07-04 12:30 ` [PATCH 9/11] arch/x86_64/kernel/process.c: " Dan Aloni
2007-07-04 12:30 ` [PATCH 10/11] drivers/block/rd.c: " Dan Aloni
2007-07-05 17:59   ` Randy Dunlap [this message]
2007-07-04 12:30 ` [PATCH 11/11] kernel/sched.c: " Dan Aloni
2007-07-05 11:24   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070705105942.ec6396fe.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=da-x@monatomic.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®