[PATCH 1/11] arch/x86_64/kernel/aperture.c: lower printk severity

[PATCH 1/11] arch/x86_64/kernel/aperture.c: lower printk severity

[Dan Aloni]

Users that use kernel log filtering (e.g. via syslogd or a proprietry
method) wouldn't like to see warning prints that are not really warnings.

Signed-off-by: Dan Aloni <da-x@monatomic.org>
---
 arch/x86_64/kernel/aperture.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86_64/kernel/aperture.c b/arch/x86_64/kernel/aperture.c
index a3d450d..3b63074 100644
--- a/arch/x86_64/kernel/aperture.c
+++ b/arch/x86_64/kernel/aperture.c
@@ -214,7 +214,7 @@ void __init iommu_hole_init(void)
 	if (iommu_aperture_disabled || !fix_aperture || !early_pci_allowed())
 		return;
 
-	printk("Checking aperture...\n"); 
+	printk(KERN_INFO  "Checking aperture...\n");
 
 	fix = 0;
 	for (num = 24; num < 32; num++) {		
-- 
1.4.4.3


-- 
Dan Aloni
XIV LTD, http://www.xivstorage.com
da-x (at) monatomic.org, dan (at) xiv.co.il

[PATCH 2/11] arch/x86_64/kernel/apic.c: lower printk severity

[Dan Aloni]

Signed-off-by: Dan Aloni <da-x@monatomic.org>
---
 arch/x86_64/kernel/apic.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86_64/kernel/apic.c b/arch/x86_64/kernel/apic.c
index 1b0e07b..243116f 100644
--- a/arch/x86_64/kernel/apic.c
+++ b/arch/x86_64/kernel/apic.c
@@ -868,7 +868,7 @@ static int __init calibrate_APIC_clock(void)
 		result = (apic_start - apic) * 1000L * tsc_khz /
 					(tsc - tsc_start);
 	}
-	printk("result %d\n", result);
+	printk(KERN_DEBUG "result %d\n", result);
 
 
 	printk(KERN_INFO "Detected %d.%03d MHz APIC timer.\n",
-- 
1.4.4.3


-- 
Dan Aloni
XIV LTD, http://www.xivstorage.com
da-x (at) monatomic.org, dan (at) xiv.co.il

[PATCH 3/11] arch/x86_64/kernel/e820.c: lower printk severity

[Dan Aloni]

Signed-off-by: Dan Aloni <da-x@monatomic.org>
---
 arch/x86_64/kernel/e820.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86_64/kernel/e820.c b/arch/x86_64/kernel/e820.c
index 13c6c37..47a8ce6 100644
--- a/arch/x86_64/kernel/e820.c
+++ b/arch/x86_64/kernel/e820.c
@@ -355,7 +355,7 @@ void __init e820_print_map(char *who)
 	int i;
 
 	for (i = 0; i < e820.nr_map; i++) {
-		printk(" %s: %016Lx - %016Lx ", who,
+		printk(KERN_INFO " %s: %016Lx - %016Lx ", who,
 			(unsigned long long) e820.map[i].addr,
 			(unsigned long long) (e820.map[i].addr + e820.map[i].size));
 		switch (e820.map[i].type) {
-- 
1.4.4.3


-- 
Dan Aloni
XIV LTD, http://www.xivstorage.com
da-x (at) monatomic.org, dan (at) xiv.co.il

[PATCH 4/11] net/ipv4/netfilter/ip_tables.c: lower printk severity

[Dan Aloni]

Signed-off-by: Dan Aloni <da-x@monatomic.org>
---
 net/ipv4/netfilter/ip_tables.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/ipv4/netfilter/ip_tables.c b/net/ipv4/netfilter/ip_tables.c
index 9bacf1a..9a6354e 100644
--- a/net/ipv4/netfilter/ip_tables.c
+++ b/net/ipv4/netfilter/ip_tables.c
@@ -2230,7 +2230,7 @@ static int __init ip_tables_init(void)
 	if (ret < 0)
 		goto err5;
 
-	printk("ip_tables: (C) 2000-2006 Netfilter Core Team\n");
+	printk(KERN_INFO "ip_tables: (C) 2000-2006 Netfilter Core Team\n");
 	return 0;
 
 err5:
-- 
1.4.4.3


-- 
Dan Aloni
XIV LTD, http://www.xivstorage.com
da-x (at) monatomic.org, dan (at) xiv.co.il

[PATCH 5/11] drivers/char/ipmi/ipmi_poweroff.c: lower printk severity

[Dan Aloni]

Signed-off-by: Dan Aloni <da-x@monatomic.org>
---
 drivers/char/ipmi/ipmi_poweroff.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_poweroff.c b/drivers/char/ipmi/ipmi_poweroff.c
index e02893b..b86186d 100644
--- a/drivers/char/ipmi/ipmi_poweroff.c
+++ b/drivers/char/ipmi/ipmi_poweroff.c
@@ -679,7 +679,7 @@ static int ipmi_poweroff_init (void)
 {
 	int rv;
 
-	printk ("Copyright (C) 2004 MontaVista Software -"
+	printk (KERN_INFO "Copyright (C) 2004 MontaVista Software -"
 		" IPMI Powerdown via sys_reboot.\n");
 
 	if (poweroff_powercycle)
-- 
1.4.4.3


-- 
Dan Aloni
XIV LTD, http://www.xivstorage.com
da-x (at) monatomic.org, dan (at) xiv.co.il

[PATCH 6/11] drivers/char/ipmi/ipmi_si_intf.c: lower printk severity

[Dan Aloni]

Signed-off-by: Dan Aloni <da-x@monatomic.org>
---
 drivers/char/ipmi/ipmi_si_intf.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 78e1b96..4edfdda 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -2857,7 +2857,7 @@ static int try_smi_init(struct smi_info *new_smi)
 
 	mutex_unlock(&smi_infos_lock);
 
-	printk(" IPMI %s interface initialized\n",si_to_str[new_smi->si_type]);
+	printk(KERN_INFO "IPMI %s interface initialized\n",si_to_str[new_smi->si_type]);
 
 	return 0;
 
-- 
1.4.4.3


-- 
Dan Aloni
XIV LTD, http://www.xivstorage.com
da-x (at) monatomic.org, dan (at) xiv.co.il

[PATCH 7/11] mm/page_alloc.c: lower printk severity

[Dan Aloni]

Signed-off-by: Dan Aloni <da-x@monatomic.org>
---
 mm/page_alloc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 05ace44..b324bc2 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -3361,7 +3361,7 @@ void *__init alloc_large_system_hash(const char *tablename,
 	if (!table)
 		panic("Failed to allocate %s hash table\n", tablename);
 
-	printk("%s hash table entries: %d (order: %d, %lu bytes)\n",
+	printk(KERN_INFO "%s hash table entries: %d (order: %d, %lu bytes)\n",
 	       tablename,
 	       (1U << log2qty),
 	       ilog2(size) - PAGE_SHIFT,
-- 
1.4.4.3


-- 
Dan Aloni
XIV LTD, http://www.xivstorage.com
da-x (at) monatomic.org, dan (at) xiv.co.il

[PATCH 8/11] drivers/acpi/pci_link.c: lower printk severity

[Dan Aloni]

Signed-off-by: Dan Aloni <da-x@monatomic.org>
---
 drivers/acpi/pci_link.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c
index acc5947..3448edd 100644
--- a/drivers/acpi/pci_link.c
+++ b/drivers/acpi/pci_link.c
@@ -733,7 +733,7 @@ static int acpi_pci_link_add(struct acpi_device *device)
 	/* query and set link->irq.active */
 	acpi_pci_link_get_current(link);
 
-	printk(PREFIX "%s [%s] (IRQs", acpi_device_name(device),
+	printk(KERN_INFO PREFIX "%s [%s] (IRQs", acpi_device_name(device),
 	       acpi_device_bid(device));
 	for (i = 0; i < link->irq.possible_count; i++) {
 		if (link->irq.active == link->irq.possible[i]) {
-- 
1.4.4.3


-- 
Dan Aloni
XIV LTD, http://www.xivstorage.com
da-x (at) monatomic.org, dan (at) xiv.co.il

[PATCH 9/11] arch/x86_64/kernel/process.c: lower printk severity

[Dan Aloni]

Signed-off-by: Dan Aloni <da-x@monatomic.org>
---
 arch/x86_64/kernel/process.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86_64/kernel/process.c b/arch/x86_64/kernel/process.c
index 5909039..cd2a3cd 100644
--- a/arch/x86_64/kernel/process.c
+++ b/arch/x86_64/kernel/process.c
@@ -278,7 +278,7 @@ void __cpuinit select_idle_routine(const struct cpuinfo_x86 *c)
 		 */
 		if (!pm_idle) {
 			if (!printed) {
-				printk("using mwait in idle threads.\n");
+				printk(KERN_INFO "using mwait in idle threads.\n");
 				printed = 1;
 			}
 			pm_idle = mwait_idle;
-- 
1.4.4.3


-- 
Dan Aloni
XIV LTD, http://www.xivstorage.com
da-x (at) monatomic.org, dan (at) xiv.co.il

[PATCH 10/11] drivers/block/rd.c: lower printk severity

[Dan Aloni]

Signed-off-by: Dan Aloni <da-x@monatomic.org>
---
 drivers/block/rd.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/block/rd.c b/drivers/block/rd.c
index a1512da..3b974f8 100644
--- a/drivers/block/rd.c
+++ b/drivers/block/rd.c
@@ -463,9 +463,9 @@ static int __init rd_init(void)
 	}
 
 	/* rd_size is given in kB */
-	printk("RAMDISK driver initialized: "
-		"%d RAM disks of %dK size %d blocksize\n",
-		CONFIG_BLK_DEV_RAM_COUNT, rd_size, rd_blocksize);
+	printk(KERN_INFO "RAMDISK driver initialized: "
+	       "%d RAM disks of %dK size %d blocksize\n",
+	       CONFIG_BLK_DEV_RAM_COUNT, rd_size, rd_blocksize);
 
 	return 0;
 out:
-- 
1.4.4.3


-- 
Dan Aloni
XIV LTD, http://www.xivstorage.com
da-x (at) monatomic.org, dan (at) xiv.co.il

Re: [PATCH 10/11] drivers/block/rd.c: lower printk severity

[Randy Dunlap]

On Wed, 4 Jul 2007 15:30:22 +0300 Dan Aloni wrote:

> Signed-off-by: Dan Aloni <da-x@monatomic.org>
> ---
>  drivers/block/rd.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/block/rd.c b/drivers/block/rd.c
> index a1512da..3b974f8 100644
> --- a/drivers/block/rd.c
> +++ b/drivers/block/rd.c
> @@ -463,9 +463,9 @@ static int __init rd_init(void)
>  	}
>  
>  	/* rd_size is given in kB */
> -	printk("RAMDISK driver initialized: "
> -		"%d RAM disks of %dK size %d blocksize\n",
> -		CONFIG_BLK_DEV_RAM_COUNT, rd_size, rd_blocksize);
> +	printk(KERN_INFO "RAMDISK driver initialized: "
> +	       "%d RAM disks of %dK size %d blocksize\n",
> +	       CONFIG_BLK_DEV_RAM_COUNT, rd_size, rd_blocksize);
>  
>  	return 0;
>  out:
> -- 

Hi Dan,
All of the changes look good to me except for this one.
The change to use 7 spaces to align the strings is unnecessary.

Thanks.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

[PATCH 11/11] kernel/sched.c: lower printk severity

[Dan Aloni]

Signed-off-by: Dan Aloni <da-x@monatomic.org>
---
 kernel/sched.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index 50e1a31..45e9534 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -6249,7 +6249,7 @@ static void calibrate_migration_costs(const cpumask_t *cpu_map)
 #endif
 		);
 	if (system_state == SYSTEM_BOOTING && num_online_cpus() > 1) {
-		printk("migration_cost=");
+		printk(KERN_INFO "migration_cost=");
 		for (distance = 0; distance <= max_distance; distance++) {
 			if (distance)
 				printk(",");
-- 
1.4.4.3


-- 
Dan Aloni
XIV LTD, http://www.xivstorage.com
da-x (at) monatomic.org, dan (at) xiv.co.il

Re: [PATCH 11/11] kernel/sched.c: lower printk severity

[Ingo Molnar]

* Dan Aloni <da-x@monatomic.org> wrote:

> Signed-off-by: Dan Aloni <da-x@monatomic.org>

Acked-by: Ingo Molnar <mingo@elte.hu>

	Ingo