* Remove unneded lock_kernel() in drivers/block/loop.c
@ 2007-07-08 19:11 Diego Woitasen
0 siblings, 0 replies; only message in thread
From: Diego Woitasen @ 2007-07-08 19:11 UTC (permalink / raw)
To: Andrew Morton, lkml - Kernel Mailing List
This patch remove the unneeded lock_kernel() in drivers/block/loop.c. I
read the code and this lock_kernel() doesn't protect anything. Loopback
code use lo_ctl_mutex for syncronization.
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 0ed5470..1cc004e 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1286,7 +1286,6 @@ static long lo_compat_ioctl(struct file *file, unsigned int cmd, unsigned long a
struct loop_device *lo = inode->i_bdev->bd_disk->private_data;
int err;
- lock_kernel();
switch(cmd) {
case LOOP_SET_STATUS:
mutex_lock(&lo->lo_ctl_mutex);
@@ -1312,7 +1311,6 @@ static long lo_compat_ioctl(struct file *file, unsigned int cmd, unsigned long a
err = -ENOIOCTLCMD;
break;
}
- unlock_kernel();
return err;
}
#endif
--
--------------
Diego Woitasen
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-07-08 19:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-07-08 19:11 Remove unneded lock_kernel() in drivers/block/loop.c Diego Woitasen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®