* [2.6 patch] i386: intel_cacheinfo.c:find_num_cache_leaves() should be __cpuinit
@ 2007-07-10 12:44 Adrian Bunk
0 siblings, 0 replies; only message in thread
From: Adrian Bunk @ 2007-07-10 12:44 UTC (permalink / raw)
To: linux-kernel
This patch fixes the following section mismatch:
<-- snip -->
...
MODPOST vmlinux
WARNING: arch/i386/kernel/built-in.o(.text+0xb6a7): Section mismatch: reference to .init.text:find_num_cache_leaves (between 'init_intel_cacheinfo' and 'cache_shared_cpu_map_setup')
...
<-- snip -->
It could be __init_refok, but gcc >= 4.0 anyway inlines it into the
__cpuinit init_intel_cacheinfo(), and IMHO it's too small
for "noinline __init".
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
--- linux-2.6.22-rc6-mm1/arch/i386/kernel/cpu/intel_cacheinfo.c.old 2007-07-10 04:21:03.000000000 +0200
+++ linux-2.6.22-rc6-mm1/arch/i386/kernel/cpu/intel_cacheinfo.c 2007-07-10 04:24:27.000000000 +0200
@@ -275,8 +275,7 @@
return 0;
}
-/* will only be called once; __init is safe here */
-static int __init find_num_cache_leaves(void)
+static int __cpuinit find_num_cache_leaves(void)
{
unsigned int eax, ebx, ecx, edx;
union _cpuid4_leaf_eax cache_eax;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-07-10 12:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-07-10 12:44 [2.6 patch] i386: intel_cacheinfo.c:find_num_cache_leaves() should be __cpuinit Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome