From: Ingo Molnar <mingo@elte.hu>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Greg KH <gregkh@suse.de>, Chris Wright <chrisw@sous-sol.org>,
Ivo van Doorn <IvDoorn@gmail.com>, Dmitry Torokhov <dtor@mail.ru>,
"David S. Miller" <davem@davemloft.net>
Subject: [patch] net/input: fix net/rfkill/rfkill-input.c bug on 64-bit systems
Date: Thu, 12 Jul 2007 14:45:03 +0200 [thread overview]
Message-ID: <20070712124503.GA16633@elte.hu> (raw)
From: Ingo Molnar <mingo@elte.hu>
Subject: [patch] net/input: fix net/rfkill/rfkill-input.c bug on 64-bit systems
this recent commit:
commit cf4328cd949c2086091c62c5685f1580fe9b55e4
Author: Ivo van Doorn <IvDoorn@gmail.com>
Date: Mon May 7 00:34:20 2007 -0700
[NET]: rfkill: add support for input key to control wireless radio
added this 64-bit bug:
....
unsigned int flags;
spin_lock_irqsave(&task->lock, flags);
....
irq 'flags' must be unsigned long, not unsigned int. The -rt tree has
strict checks about this on 64-bit so this triggered a build failure.
For -stable too i suspect.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Index: linux-rt.q/net/rfkill/rfkill-input.c
===================================================================
--- linux-rt.q.orig/net/rfkill/rfkill-input.c
+++ linux-rt.q/net/rfkill/rfkill-input.c
@@ -55,7 +55,7 @@ static void rfkill_task_handler(struct w
static void rfkill_schedule_toggle(struct rfkill_task *task)
{
- unsigned int flags;
+ unsigned long flags;
spin_lock_irqsave(&task->lock, flags);
next reply other threads:[~2007-07-12 12:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-12 12:45 Ingo Molnar [this message]
2007-07-12 13:29 ` Dmitry Torokhov
2007-07-15 1:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070712124503.GA16633@elte.hu \
--to=mingo@elte.hu \
--cc=IvDoorn@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chrisw@sous-sol.org \
--cc=davem@davemloft.net \
--cc=dtor@mail.ru \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®