From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org,
"Andrew Morton" <akpm@linux-foundation.org>,
"Greg KH" <gregkh@suse.de>, "Chris Wright" <chrisw@sous-sol.org>,
"Ivo van Doorn" <IvDoorn@gmail.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [patch] net/input: fix net/rfkill/rfkill-input.c bug on 64-bit systems
Date: Thu, 12 Jul 2007 09:29:54 -0400 [thread overview]
Message-ID: <d120d5000707120629n53f123ccs5a933c71c9a14542@mail.gmail.com> (raw)
In-Reply-To: <20070712124503.GA16633@elte.hu>
On 7/12/07, Ingo Molnar <mingo@elte.hu> wrote:
> From: Ingo Molnar <mingo@elte.hu>
> Subject: [patch] net/input: fix net/rfkill/rfkill-input.c bug on 64-bit systems
>
> this recent commit:
>
> commit cf4328cd949c2086091c62c5685f1580fe9b55e4
> Author: Ivo van Doorn <IvDoorn@gmail.com>
> Date: Mon May 7 00:34:20 2007 -0700
>
> [NET]: rfkill: add support for input key to control wireless radio
>
> added this 64-bit bug:
>
> ....
> unsigned int flags;
>
> spin_lock_irqsave(&task->lock, flags);
> ....
>
> irq 'flags' must be unsigned long, not unsigned int. The -rt tree has
> strict checks about this on 64-bit so this triggered a build failure.
>
Yep, my fault.
> For -stable too i suspect.
>
I don't think anyone uses rfkill in mainline yet. People were asking
to add it so that they can develop against it but I guess I should
have waited for the real user before pushing rfkill to David...
ANyway, I see it is being used in wireless-dev so it is not completely
useless ;)
--
Dmitry
next prev parent reply other threads:[~2007-07-12 13:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-12 12:45 Ingo Molnar
2007-07-12 13:29 ` Dmitry Torokhov [this message]
2007-07-15 1:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d5000707120629n53f123ccs5a933c71c9a14542@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=IvDoorn@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chrisw@sous-sol.org \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®