From: Joe Jin <joe.jin@oracle.com>
To: akpm@osdl.org, bill.irwin@oracle.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Add nid sanity on alloc_pages_node
Date: Fri, 13 Jul 2007 10:45:07 +0800 [thread overview]
Message-ID: <20070713024507.GA19438@joejin-pc.cn.oracle.com> (raw)
This patch add nid sanity check on alloc_pages_node().
While two process change nr_hugepages at a system, alloc_fresh_huge_page()
been called, at this function, nid defined as a static variable, but, there
is not any protection of, if 2 process called at the same time, maybe pass a
invalid nid to alloc_pages_node.
We have hit it by following scripts:
#!/bin/bash
while : ; do
echo 1000000000000 > /proc/sys/vm/nr_hugepages
echo 1 > /proc/sys/vm/nr_hugepages
echo 10000000000000000000 > /proc/sys/vm/nr_hugepages
echo 0 > /proc/sys/vm/nr_hugepages
done
Run the script at _two_ difference terminal, after a short time, a kernel panic
info will print.
Signed-off-by: Joe Jin <joe.jin@oracle.com>
---
--- linux-2.6.22/include/linux/gfp.h.orig 2007-07-12 15:06:23.000000000 +0800
+++ linux-2.6.22/include/linux/gfp.h 2007-07-12 15:02:59.000000000 +0800
@@ -133,6 +133,9 @@
/* Unknown node is current node */
if (nid < 0)
nid = numa_node_id();
+
+ if (unlikely(nid == MAX_NUMNODES))
+ nid = first_node(node_online_map);
return __alloc_pages(gfp_mask, order,
NODE_DATA(nid)->node_zonelists + gfp_zone(gfp_mask));
next reply other threads:[~2007-07-13 2:46 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 2:45 Joe Jin [this message]
2007-07-13 5:18 ` Andrew Morton
2007-07-13 6:40 ` Joe Jin
2007-07-13 6:49 ` Andrew Morton
2007-07-13 6:57 ` Andrew Morton
2007-07-13 8:29 ` Paul Jackson
2007-07-13 8:38 ` Andrew Morton
2007-07-13 8:43 ` Paul Jackson
2007-07-13 8:49 ` Andrew Morton
2007-07-13 8:54 ` Paul Jackson
2007-07-13 12:48 ` Benjamin Herrenschmidt
2007-07-13 8:03 ` Joe Jin
2007-07-13 8:15 ` Andrew Morton
2007-07-13 12:18 ` Joe Jin
2007-07-13 12:42 ` Paul Jackson
2007-07-14 17:40 ` Nish Aravamudan
2007-07-14 18:04 ` Andrew Morton
2007-07-14 20:47 ` Nish Aravamudan
2007-07-13 8:04 ` gurudas pai
2007-07-13 8:19 ` Andrew Morton
2007-07-13 12:37 ` gurudas pai
2007-07-13 8:37 ` Joe Jin
2007-07-13 8:44 ` Andrew Morton
2007-07-17 15:04 ` Hugh Dickins
2007-07-17 16:32 ` Andrew Morton
2007-07-17 17:26 ` Hugh Dickins
2007-07-17 18:58 ` Andrew Morton
2007-07-17 19:49 ` Hugh Dickins
2007-07-17 20:01 ` Andrew Morton
2007-07-17 20:35 ` Hugh Dickins
2007-07-18 1:40 ` Joe Jin
2007-07-18 4:49 ` Hugh Dickins
2007-07-18 5:45 ` Andrew Morton
2007-07-18 7:34 ` Joe Jin
2007-07-18 6:32 ` Joe Jin
2007-07-18 8:09 ` Joe Jin
2007-07-18 8:35 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070713024507.GA19438@joejin-pc.cn.oracle.com \
--to=joe.jin@oracle.com \
--cc=akpm@osdl.org \
--cc=bill.irwin@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®