From: Joe Jin <joe.jin@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Joe Jin <joe.jin@oracle.com>,
bill.irwin@oracle.com, linux-kernel@vger.kernel.org,
gurudas.pai@oracle.com
Subject: Re: [PATCH] Add nid sanity on alloc_pages_node
Date: Fri, 13 Jul 2007 16:37:32 +0800 [thread overview]
Message-ID: <20070713083732.GC21833@joejin-pc.cn.oracle.com> (raw)
In-Reply-To: <20070712234938.c77f3a48.akpm@linux-foundation.org>
>
> if (nid > MAX_NUMNODES) then that is a bug and we should report it (doing
> this via a BUG() is OK) rather than quietly covering it up.
I have create a patch to check if nid > MAX_NUMNODES, please apply it
thanks
Signed-off-by: Joe Jin <joe.jin@oracle.com>
---
--- linux-2.6.22/include/linux/gfp.h.orig 2007-07-12 15:06:23.000000000 +0800
+++ linux-2.6.22/include/linux/gfp.h 2007-07-13 16:23:52.000000000 +0800
@@ -127,6 +127,8 @@ FASTCALL(__alloc_pages(gfp_t, unsigned i
static inline struct page *alloc_pages_node(int nid, gfp_t gfp_mask,
unsigned int order)
{
+ BUG_ON(nid > MAX_NUMNODES);
+
if (unlikely(order >= MAX_ORDER))
return NULL;
next prev parent reply other threads:[~2007-07-13 8:39 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 2:45 Joe Jin
2007-07-13 5:18 ` Andrew Morton
2007-07-13 6:40 ` Joe Jin
2007-07-13 6:49 ` Andrew Morton
2007-07-13 6:57 ` Andrew Morton
2007-07-13 8:29 ` Paul Jackson
2007-07-13 8:38 ` Andrew Morton
2007-07-13 8:43 ` Paul Jackson
2007-07-13 8:49 ` Andrew Morton
2007-07-13 8:54 ` Paul Jackson
2007-07-13 12:48 ` Benjamin Herrenschmidt
2007-07-13 8:03 ` Joe Jin
2007-07-13 8:15 ` Andrew Morton
2007-07-13 12:18 ` Joe Jin
2007-07-13 12:42 ` Paul Jackson
2007-07-14 17:40 ` Nish Aravamudan
2007-07-14 18:04 ` Andrew Morton
2007-07-14 20:47 ` Nish Aravamudan
2007-07-13 8:04 ` gurudas pai
2007-07-13 8:19 ` Andrew Morton
2007-07-13 12:37 ` gurudas pai
2007-07-13 8:37 ` Joe Jin [this message]
2007-07-13 8:44 ` Andrew Morton
2007-07-17 15:04 ` Hugh Dickins
2007-07-17 16:32 ` Andrew Morton
2007-07-17 17:26 ` Hugh Dickins
2007-07-17 18:58 ` Andrew Morton
2007-07-17 19:49 ` Hugh Dickins
2007-07-17 20:01 ` Andrew Morton
2007-07-17 20:35 ` Hugh Dickins
2007-07-18 1:40 ` Joe Jin
2007-07-18 4:49 ` Hugh Dickins
2007-07-18 5:45 ` Andrew Morton
2007-07-18 7:34 ` Joe Jin
2007-07-18 6:32 ` Joe Jin
2007-07-18 8:09 ` Joe Jin
2007-07-18 8:35 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070713083732.GC21833@joejin-pc.cn.oracle.com \
--to=joe.jin@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=bill.irwin@oracle.com \
--cc=gurudas.pai@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome