From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: david@lang.hm
Cc: Joseph Fannin <jfannin@gmail.com>,
Oliver Neukum <oliver@neukum.org>,
Jeremy Maitin-Shepard <jbms@cmu.edu>,
"Huang, Ying" <ying.huang@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Pavel Machek <pavel@ucw.cz>,
nigel@nigel.suspend2.net, linux-kernel@vger.kernel.org,
linux-pm@lists.linux-foundation.org
Subject: Re: Hibernating To Swap Considered Harmful
Date: Tue, 17 Jul 2007 13:54:45 +0200 [thread overview]
Message-ID: <200707171354.46957.rjw@sisk.pl> (raw)
In-Reply-To: <Pine.LNX.4.64.0707170030460.19248@asgard.lang.hm>
On Tuesday, 17 July 2007 09:34, david@lang.hm wrote:
> On Tue, 17 Jul 2007, Joseph Fannin wrote:
>
> > On Mon, Jul 16, 2007 at 11:42:08PM -0700, david@lang.hm wrote:
> >> On Tue, 17 Jul 2007, Joseph Fannin wrote:
> >
> >>> root is free to "dd if=/dev/random of=/dev/mem". Root owned
> >>> daemons which do bad things are bugs.
> >>
> >> in this case it would be more like
> >>
> >> dd if=/block0 of=/dev/sda1 count=1 bs=4096 skip=5000
> >> dd if=/block1 of=/dev/sda1 count=1 bs=4096 skip=5050
> >> dd if=/block2 of=/dev/sda1 count=1 bs=4096 skip=5400
> >> etc
> >>
> >> to write the blocks to the raw parition in the right place
> >
> > What I meant by that was that root is allowed to shoot himself in the
> > foot. Nothing stops root from opening a swap/hibernate file, which
> > would put it in cache, and cause it to be inconsistant if a
> > hibernation image was written to it behind the kernel's back.
> >
> > That would be a very stupid thing to do, however. There's no reason
> > to open that file, unless you know *exactly* what you are doing, in
> > which case the onus is on you to get it right.
> >
> > But you have a point. The swap file could be very fragmented. It
> > might often be so, even.
> >
> > Still, is this better than exporting the kernel's swap internals
> > (which has never been a public interface before)?
> >
> > Does it make the interface that writing hibernation images to swap
> > imposes any better?
> >
> > Even if hibernation files are no less complicated to support than
> > hibernating to swap files (which isn't a forgone conclusion) , there
> > are plenty of reasons writing hibernation images to swap doesn't make
> > sense.
> >
> >
> >>> Again, supporting swap files (*which is not optional*) requires the
> >>> very same support.
> >>
> >> in the kexec model why would the second kernel care about swap files at
> >> all? (unles it chooses to write to them, in which case it is exactly the
> >> same support, but unless it writes to them it doesn't need to care)
> >
> > My point is that no extra work is required to write hibernation images
> > to dedicated files than to write hibernation images to swap files.
> >
> > If swap files are to be supported, then, there's no technical reason
> > not to support dedicated hibernation files. Dedicated hibernation
> > files are better, and there's no reason not to implement them.
>
> I agree with your point, but the reverse is not true, the ability to write
> to a dedicated hibernation file does not produce the capacity to write to
> a swap file, and I do question the 'requirement' to write the hibernation
> image to the swap file.
There's no such requirement, it's just been easier to implement.
Greetings,
Rafael
--
"Premature optimization is the root of all evil." - Donald Knuth
next prev parent reply other threads:[~2007-07-17 11:46 UTC|newest]
Thread overview: 121+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-11 15:30 [PATCH 0/2] Kexec jump: The first step to kexec base hibernation Huang, Ying
2007-07-11 11:13 ` Pavel Machek
2007-07-12 16:28 ` Huang, Ying
2007-07-12 8:54 ` Pavel Machek
2007-07-13 23:18 ` Huang, Ying
2007-07-12 0:22 ` Andrew Morton
2007-07-12 5:48 ` Jeremy Fitzhardinge
2007-07-12 6:43 ` david
2007-07-12 12:46 ` Rafael J. Wysocki
2007-07-12 13:51 ` Mark Lord
2007-07-12 14:49 ` Pavel Machek
2007-07-12 15:35 ` Rafael J. Wysocki
2007-07-12 16:03 ` Mark Lord
2007-07-12 16:35 ` Mark Lord
2007-07-12 20:05 ` Jeremy Maitin-Shepard
2007-07-13 2:38 ` Mark Lord
2007-07-12 16:09 ` [linux-pm] " Alan Stern
2007-07-12 18:49 ` david
2007-07-12 18:42 ` david
2007-07-12 19:20 ` Rafael J. Wysocki
2007-07-12 19:14 ` david
2007-07-12 19:45 ` Rafael J. Wysocki
2007-07-12 17:09 ` Huang, Ying
2007-07-12 12:47 ` Rafael J. Wysocki
2007-07-12 12:38 ` Rafael J. Wysocki
2007-07-12 14:43 ` Huang, Ying
2007-07-12 7:03 ` david
2007-07-12 17:18 ` Huang, Ying
2007-07-12 10:10 ` david
2007-07-12 13:01 ` Rafael J. Wysocki
2007-07-12 13:22 ` jimmy bahuleyan
2007-07-12 19:03 ` david
2007-07-12 13:55 ` Mark Lord
2007-07-12 19:05 ` david
2007-07-12 14:06 ` Pavel Machek
2007-07-12 12:53 ` Rafael J. Wysocki
2007-07-12 18:57 ` david
2007-07-12 19:34 ` Rafael J. Wysocki
2007-07-12 19:55 ` Jeremy Maitin-Shepard
2007-07-12 20:45 ` Rafael J. Wysocki
2007-07-13 3:12 ` david
2007-07-13 9:17 ` Rafael J. Wysocki
2007-07-13 9:25 ` david
2007-07-13 11:41 ` Rafael J. Wysocki
2007-07-14 7:51 ` david
2007-07-14 8:33 ` david
2007-07-14 9:24 ` Rafael J. Wysocki
2007-07-14 20:00 ` Rafael J. Wysocki
2007-07-14 20:34 ` david
2007-07-14 21:06 ` Rafael J. Wysocki
2007-07-14 21:13 ` david
2007-07-15 10:31 ` Rafael J. Wysocki
2007-07-15 19:23 ` david
2007-07-15 22:59 ` Rafael J. Wysocki
2007-07-15 23:22 ` david
2007-07-16 12:17 ` Rafael J. Wysocki
2007-07-16 14:42 ` Huang, Ying
2007-07-16 15:40 ` Rafael J. Wysocki
2007-07-17 4:18 ` david
2007-07-17 11:46 ` Rafael J. Wysocki
2007-07-14 21:34 ` david
2007-07-15 10:39 ` Rafael J. Wysocki
2007-07-15 19:33 ` david
2007-07-15 23:11 ` Rafael J. Wysocki
2007-07-15 23:33 ` david
2007-07-13 3:06 ` david
2007-07-13 5:42 ` Hibernating To Swap Considered Harmful Joseph Fannin
2007-07-13 5:57 ` david
2007-07-13 6:20 ` Joseph Fannin
2007-07-13 6:27 ` david
2007-07-13 7:15 ` Joseph Fannin
2007-07-13 14:35 ` Jeremy Maitin-Shepard
2007-07-17 0:12 ` Joseph Fannin
2007-07-17 5:44 ` Oliver Neukum
2007-07-17 6:28 ` Joseph Fannin
2007-07-17 6:42 ` david
2007-07-17 7:26 ` Joseph Fannin
2007-07-17 7:34 ` david
2007-07-17 11:54 ` Rafael J. Wysocki [this message]
2007-07-17 11:52 ` Rafael J. Wysocki
2007-07-17 7:10 ` Oliver Neukum
2007-07-13 9:30 ` Rafael J. Wysocki
2007-07-14 0:45 ` Joseph Fannin
2007-07-14 9:48 ` Rafael J. Wysocki
2007-07-16 5:37 ` Joseph Fannin
2007-07-13 9:29 ` [PATCH 0/2] Kexec jump: The first step to kexec base hibernation Rafael J. Wysocki
2007-07-13 9:38 ` david
2007-07-13 11:59 ` Rafael J. Wysocki
2007-07-13 14:37 ` [linux-pm] " Alan Stern
2007-07-13 15:31 ` Rafael J. Wysocki
2007-07-14 7:13 ` david
2007-07-13 15:12 ` Jeremy Maitin-Shepard
2007-07-13 15:45 ` Rafael J. Wysocki
2007-07-13 15:50 ` Alan Stern
2007-07-13 16:54 ` Eric W. Biederman
2007-07-13 18:15 ` Alan Stern
2007-07-13 21:08 ` Rafael J. Wysocki
2007-07-13 20:55 ` Rafael J. Wysocki
2007-07-13 16:48 ` Jeremy Maitin-Shepard
2007-07-13 21:23 ` Rafael J. Wysocki
2007-07-14 7:12 ` david
2007-07-13 17:32 ` Huang, Ying
2007-07-13 12:01 ` Rafael J. Wysocki
2007-07-12 16:32 ` Eric W. Biederman
2007-07-12 19:09 ` david
2007-07-12 19:49 ` Eric W. Biederman
2007-07-13 23:15 ` Huang, Ying
2007-07-13 16:43 ` Eric W. Biederman
2007-07-14 5:48 ` Huang, Ying
2007-07-14 9:59 ` Rafael J. Wysocki
2007-07-14 10:55 ` Huang, Ying
2007-07-14 19:16 ` Rafael J. Wysocki
2007-07-15 9:30 ` Huang, Ying
2007-07-15 10:49 ` Rafael J. Wysocki
2007-07-24 14:00 ` Huang, Ying
2007-07-24 15:27 ` Rafael J. Wysocki
2007-07-17 8:13 ` david
2007-07-17 11:59 ` Rafael J. Wysocki
2007-07-17 12:48 ` Huang, Ying
2007-07-17 14:22 ` Rafael J. Wysocki
2007-07-18 0:25 ` david
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707171354.46957.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=david@lang.hm \
--cc=jbms@cmu.edu \
--cc=jfannin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=nigel@nigel.suspend2.net \
--cc=oliver@neukum.org \
--cc=pavel@ucw.cz \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®