* Re: [Cbe-oss-dev] [patch 11/13] cell: driver for DDR2 memory on AXON
[not found] ` <20070719101230.GA4553@lst.de>
@ 2007-07-19 14:49 ` Arnd Bergmann
2007-07-19 15:15 ` Alan Cox
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2007-07-19 14:49 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Andrew Morton, linux-kernel
On Thursday 19 July 2007, Christoph Hellwig wrote:
>
> > None of these seems to make any difference whatsoever, except for BLKBSZGET
> > returning non-zero on a ramdisk or dcssblk device. I think we'd be best
> > off removing bd_block_size from the kernel altogether, and I'll remove
> > it from the axon-ram driver now.
>
> Yes, please. I even have patches that only pass struct gendisk to block
> device ->open, so this couldn't work anymore anyway. And yes, the
> ramdisk driver is doing some really odd things.
Any suggestion on what BLKBSZGET should return?
1) blocksize = 0 (same as it does already for most devices)
2) return -EINVAL
3) same as BLKSSZGET
4) return -ENOTTY
It probably doesn't matter much as any user of BLKBSZGET is
already broken, but it would be good to do the right thing
since it is a documented interface.
Arnd <><
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-07-19 15:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20070718160439.723093835@arndb.de>
[not found] ` <200707190048.09686.arnd@arndb.de>
[not found] ` <20070719101230.GA4553@lst.de>
2007-07-19 14:49 ` [Cbe-oss-dev] [patch 11/13] cell: driver for DDR2 memory on AXON Arnd Bergmann
2007-07-19 15:15 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®