[PATCH] CONFIG_NET=n - lots of link time errors

[PATCH] CONFIG_NET=n - lots of link time errors

[Jan Engelhardt]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1430 bytes --]

Hi,


enable everything from Drivers > Networking, but deselect CONFIG_NET. 
This throws a ton of linking errors (when using CONFIG_MODULES=n), and 
probably unresolved symbols (MODULES=m). Happens in current -git, but I 
believe it dates much farther back, because this is imo just a simple 
Kconfig issue. I think we need to hand out a big 'if NET'-endif block in 
drivers/net/Kconfig. The full error log is like 120 K in size, and I 
doubt it would make sense to post it, given instructions above. I'll 
attach my (i386) .config for anyone to see it for themselves, and a 
patch proposal right below. Is it ok to add 'depends on NET' on 
NETDEVICES, or are there some network devices that can live without 
CONFIG_NET?

Thanks,
	Jan
===

Enabling drivers from "Devices > Networking" (in menuconfig), for 
example SLIP and/or PLIP, throws link time errors when CONFIG_NET itself 
is =n. Have CONFIG_NETDEVICES depend on CONFIG_NET.

Signed-off-by: Jan Engelhardt <jengelh@gmx.de>

---
 drivers/net/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Index: linux-2.6.23/drivers/net/Kconfig
===================================================================
--- linux-2.6.23.orig/drivers/net/Kconfig
+++ linux-2.6.23/drivers/net/Kconfig
@@ -5,6 +5,7 @@
 
 menuconfig NETDEVICES
 	default y if UML
+	depends on NET
 	bool "Network device support"
 	---help---
 	  You can say N here if you don't intend to connect your Linux box to

[-- Attachment #2: Type: APPLICATION/X-CONFIG, Size: 19173 bytes --]

Re: [PATCH] CONFIG_NET=n - lots of link time errors

[David Miller]

From: Jan Engelhardt <jengelh@computergmbh.de>
Date: Sat, 21 Jul 2007 18:27:38 +0200 (CEST)

> Enabling drivers from "Devices > Networking" (in menuconfig), for 
> example SLIP and/or PLIP, throws link time errors when CONFIG_NET itself 
> is =n. Have CONFIG_NETDEVICES depend on CONFIG_NET.
> 
> Signed-off-by: Jan Engelhardt <jengelh@gmx.de>

This is the second time I've seen this change in the past few
days, and people seem to hit it quite readily with randconfig.

It seems reasonable and I'll apply it, thanks Jan.

Re: [PATCH] CONFIG_NET=n - lots of link time errors

[Jan Engelhardt]

On Jul 21 2007 19:12, David Miller wrote:
>> Enabling drivers from "Devices > Networking" (in menuconfig), for 
>> example SLIP and/or PLIP, throws link time errors when CONFIG_NET itself 
>> is =n. Have CONFIG_NETDEVICES depend on CONFIG_NET.
>> 
>> Signed-off-by: Jan Engelhardt <jengelh@gmx.de>
>
>This is the second time I've seen this change in the past few
>days, and people seem to hit it quite readily with randconfig.
>
>It seems reasonable and I'll apply it, thanks Jan.

While randconfig is nice and good, this error actually came by manually
tuning the .config for a specific goal (namely: make a small kernel for an
ancient i386 without modifying any code). Turning off CONFIG_NET
was then just an idea away, because I knew that TCP was quite big.


	Jan
--