* [2.6 patch] dvb-usb/af9005-fe.c: error check fixes
@ 2007-07-23 8:01 Adrian Bunk
0 siblings, 0 replies; only message in thread
From: Adrian Bunk @ 2007-07-23 8:01 UTC (permalink / raw)
To: Luca Olivetti; +Cc: v4l-dvb-maintainer, linux-kernel
This patch:
- adds a missing error check and
- removes an error check that could never be true
Both spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/media/dvb/dvb-usb/af9005-fe.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
--- linux-2.6.22-rc6-mm1/drivers/media/dvb/dvb-usb/af9005-fe.c.old 2007-07-23 01:13:37.000000000 +0200
+++ linux-2.6.22-rc6-mm1/drivers/media/dvb/dvb-usb/af9005-fe.c 2007-07-23 01:20:58.000000000 +0200
@@ -345,8 +345,8 @@ static int af9005_reset_pre_viterbi(stru
1 & 0xff);
if (ret)
return ret;
- af9005_write_ofdm_register(state->d, xd_p_fec_super_frm_unit_15_8,
- 1 >> 8);
+ ret = af9005_write_ofdm_register(state->d, xd_p_fec_super_frm_unit_15_8,
+ 1 >> 8);
if (ret)
return ret;
/* reset pre viterbi error count */
@@ -881,10 +881,8 @@ static int af9005_fe_init(struct dvb_fro
af9005_write_register_bits(state->d, xd_I2C_reg_ofdm_rst,
reg_ofdm_rst_pos, reg_ofdm_rst_len, 1)))
return ret;
- if ((ret =
- af9005_write_register_bits(state->d, xd_I2C_reg_ofdm_rst,
- reg_ofdm_rst_pos, reg_ofdm_rst_len, 0)))
- return ret;
+ ret = af9005_write_register_bits(state->d, xd_I2C_reg_ofdm_rst,
+ reg_ofdm_rst_pos, reg_ofdm_rst_len, 0);
if (ret)
return ret;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-07-23 8:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-07-23 8:01 [2.6 patch] dvb-usb/af9005-fe.c: error check fixes Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®