[PATCH] usb/atm: fix Kconfig garbage

[PATCH] usb/atm: fix Kconfig garbage

[Borislav Petkov]

Hi there,

I don't know whether this is the proper Kconfig-way to fix this but it works ok here.

----
When entered, the menu point "USB DSL modem support" in menuconfig, path [Device Drivers->USB
Support] shows no entries but "^@" instead. The following fixes it.

Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>

--
--- linux-2.6.23-rc1/drivers/usb/atm/Kconfig.orig	2007-07-23 08:27:29.000000000 +0200
+++ linux-2.6.23-rc1/drivers/usb/atm/Kconfig	2007-07-23 08:50:55.000000000 +0200
@@ -7,7 +7,8 @@ menu "USB DSL modem support"
 
 config USB_ATM
 	tristate "USB DSL modem support"
-	depends on USB && ATM
+	depends on USB
+	select ATM
 	select CRC32
 	default n
 	help
-- 
Regards/Gruß,
    Boris.

Re: [PATCH] usb/atm: fix Kconfig garbage

[Adrian Bunk]

On Mon, Jul 23, 2007 at 08:56:04AM +0200, Borislav Petkov wrote:
> Hi there,
> 
> I don't know whether this is the proper Kconfig-way to fix this but it works ok here.
> 
> ----
> When entered, the menu point "USB DSL modem support" in menuconfig, path [Device Drivers->USB
> Support] shows no entries but "^@" instead. The following fixes it.
> 
> Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>
> 
> --
> --- linux-2.6.23-rc1/drivers/usb/atm/Kconfig.orig	2007-07-23 08:27:29.000000000 +0200
> +++ linux-2.6.23-rc1/drivers/usb/atm/Kconfig	2007-07-23 08:50:55.000000000 +0200
> @@ -7,7 +7,8 @@ menu "USB DSL modem support"
>  
>  config USB_ATM
>  	tristate "USB DSL modem support"
> -	depends on USB && ATM
> +	depends on USB
> +	select ATM
>  	select CRC32
>  	default n
>  	help

This would break the compilation with CONFIG_NET=n.

> Regards/Gruß,
>     Boris.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [PATCH] usb/atm: fix Kconfig garbage

[Borislav Petkov]

On Mon, Jul 23, 2007 at 01:53:30PM +0200, Adrian Bunk wrote:
> On Mon, Jul 23, 2007 at 08:56:04AM +0200, Borislav Petkov wrote:
> > Hi there,
> > 
> > I don't know whether this is the proper Kconfig-way to fix this but it works ok here.
> > 
> > ----
> > When entered, the menu point "USB DSL modem support" in menuconfig, path [Device Drivers->USB
> > Support] shows no entries but "^@" instead. The following fixes it.
> > 
> > Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>
> > 
> > --
> > --- linux-2.6.23-rc1/drivers/usb/atm/Kconfig.orig	2007-07-23 08:27:29.000000000 +0200
> > +++ linux-2.6.23-rc1/drivers/usb/atm/Kconfig	2007-07-23 08:50:55.000000000 +0200
> > @@ -7,7 +7,8 @@ menu "USB DSL modem support"
> >  
> >  config USB_ATM
> >  	tristate "USB DSL modem support"
> > -	depends on USB && ATM
> > +	depends on USB
> > +	select ATM
> >  	select CRC32
> >  	default n
> >  	help
> 
> This would break the compilation with CONFIG_NET=n.

Aha, so the logic behind it is that this submenu should be displayed in kconfig only if ATM 
is selected. Ok, I get it, thanks.

-- 
Regards/Gruß,
    Boris.

Re: [PATCH] usb/atm: fix Kconfig garbage

[Duncan Sands]

Hi,

> When entered, the menu point "USB DSL modem support" in menuconfig, path [Device Drivers->USB
> Support] shows no entries but "^@" instead. The following fixes it.

is the problem that there are no entries, or that "^@" is displayed?  If there are no
entries then presumably you didn't turn on ATM support.

Ciao,

Duncan.

Re: [PATCH] usb/atm: fix Kconfig garbage

[Borislav Petkov]

On Tue, Jul 24, 2007 at 10:28:55AM +0200, Duncan Sands wrote:
> Hi,
> 
> > When entered, the menu point "USB DSL modem support" in menuconfig, path [Device Drivers->USB
> > Support] shows no entries but "^@" instead. The following fixes it.
> 
> is the problem that there are no entries, or that "^@" is displayed?  If there are no
> entries then presumably you didn't turn on ATM support.

I thought simply that when "^@" is displayed then something is wrong with the
menu in Kconfig but the reason was that ATM was not enabled, that's all.

-- 
Regards/Gruß,
    Boris.