From: Ingo Molnar <mingo@elte.hu>
To: Daniel Walker <dwalker@mvista.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
linux-rt-users@vger.kernel.org
Subject: Re: [PATCH] release quicklist before free_page
Date: Mon, 23 Jul 2007 20:23:01 +0200 [thread overview]
Message-ID: <20070723182301.GA27789@elte.hu> (raw)
In-Reply-To: <1185207979.2573.55.camel@imap.mvista.com>
* Daniel Walker <dwalker@mvista.com> wrote:
> > Not quite, it uses preempt_disable() to avoid migration and stick to
> > a cpu. Without that it might end up freeing pages from another
> > quicklist.
i.e. the patch hides a debug warning and there's possibly silent data
corruption - not good.
> > How about this - compile tested only
>
> How about a comment to go with it ? Which says something like what's
> above, notes on how the locking is getting used..
how about: "if you've got some time then please also add a few comments,
because the code was quite non-obvious to me and I misunderstood it when
I tried to fix it. Thanks."
ok?
Ingo
next prev parent reply other threads:[~2007-07-23 18:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-23 15:21 Daniel Walker
2007-07-23 16:32 ` Peter Zijlstra
2007-07-23 16:26 ` Daniel Walker
2007-07-23 18:23 ` Ingo Molnar [this message]
2007-07-23 18:27 ` Daniel Walker
2007-07-23 18:58 ` Ingo Molnar
2007-07-23 19:46 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070723182301.GA27789@elte.hu \
--to=mingo@elte.hu \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®