* [PATCH] kernel-doc fixes for PCI and drivers/base/
@ 2007-07-24 4:42 Randy Dunlap
2007-07-30 19:12 ` patch kernel-doc-fixes-for-pci-and-drivers-base.patch added to gregkh-2.6 tree gregkh
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2007-07-24 4:42 UTC (permalink / raw)
To: lkml; +Cc: gregkh
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix undocumented function parameters in PCI and drivers/base.
Warning(linux-2.6.23-rc1//drivers/pci/pci.c:1526): No description found for parameter 'rq'
Warning(linux-2.6.23-rc1//drivers/base/firmware_class.c:245): No description found for parameter 'bin_attr'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/base/firmware_class.c | 1 +
drivers/pci/pci.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
--- linux-2.6.23-rc1.orig/drivers/base/firmware_class.c
+++ linux-2.6.23-rc1/drivers/base/firmware_class.c
@@ -232,6 +232,7 @@ fw_realloc_buffer(struct firmware_priv *
/**
* firmware_data_write - write method for firmware
* @kobj: kobject for the device
+ * @bin_attr: bin_attr structure
* @buffer: buffer being written
* @offset: buffer offset for write in total data store area
* @count: buffer size
--- linux-2.6.23-rc1.orig/drivers/pci/pci.c
+++ linux-2.6.23-rc1/drivers/pci/pci.c
@@ -1517,7 +1517,7 @@ EXPORT_SYMBOL(pcie_get_readrq);
/**
* pcie_set_readrq - set PCI Express maximum memory read request
* @dev: PCI device to query
- * @count: maximum memory read count in bytes
+ * @rq: maximum memory read count in bytes
* valid values are 128, 256, 512, 1024, 2048, 4096
*
* If possible sets maximum read byte count
^ permalink raw reply [flat|nested] 2+ messages in thread
* patch kernel-doc-fixes-for-pci-and-drivers-base.patch added to gregkh-2.6 tree
2007-07-24 4:42 [PATCH] kernel-doc fixes for PCI and drivers/base/ Randy Dunlap
@ 2007-07-30 19:12 ` gregkh
0 siblings, 0 replies; 2+ messages in thread
From: gregkh @ 2007-07-30 19:12 UTC (permalink / raw)
To: randy.dunlap, greg, gregkh, linux-kernel
This is a note to let you know that I've just added the patch titled
Subject: kernel-doc fixes for PCI and drivers/base/
to my gregkh-2.6 tree. Its filename is
kernel-doc-fixes-for-pci-and-drivers-base.patch
This tree can be found at
http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/
>From randy.dunlap@oracle.com Mon Jul 23 21:38:12 2007
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Mon, 23 Jul 2007 21:42:11 -0700
Subject: kernel-doc fixes for PCI and drivers/base/
To: lkml <linux-kernel@vger.kernel.org>
Cc: gregkh <greg@kroah.com>
Message-ID: <20070723214211.9beda07f.randy.dunlap@oracle.com>
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix undocumented function parameters in PCI and drivers/base.
Warning(linux-2.6.23-rc1//drivers/pci/pci.c:1526): No description found for parameter 'rq'
Warning(linux-2.6.23-rc1//drivers/base/firmware_class.c:245): No description found for parameter 'bin_attr'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/base/firmware_class.c | 1 +
drivers/pci/pci.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -232,6 +232,7 @@ fw_realloc_buffer(struct firmware_priv *
/**
* firmware_data_write - write method for firmware
* @kobj: kobject for the device
+ * @bin_attr: bin_attr structure
* @buffer: buffer being written
* @offset: buffer offset for write in total data store area
* @count: buffer size
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -1517,7 +1517,7 @@ EXPORT_SYMBOL(pcie_get_readrq);
/**
* pcie_set_readrq - set PCI Express maximum memory read request
* @dev: PCI device to query
- * @count: maximum memory read count in bytes
+ * @rq: maximum memory read count in bytes
* valid values are 128, 256, 512, 1024, 2048, 4096
*
* If possible sets maximum read byte count
Patches currently in gregkh-2.6 which might be from randy.dunlap@oracle.com are
driver/fix-doc-sysfs-rules-typos.patch
driver/kernel-doc-fixes-for-pci-and-drivers-base.patch
driver/kset-kernel-doc-cleanups.patch
pci/pci-document-pci_iomap.patch
usb/usb-usb.h-kernel-doc-additions.patch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-07-30 19:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-07-24 4:42 [PATCH] kernel-doc fixes for PCI and drivers/base/ Randy Dunlap
2007-07-30 19:12 ` patch kernel-doc-fixes-for-pci-and-drivers-base.patch added to gregkh-2.6 tree gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®