From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: "Yinghai Lu" <yhlu.kernel@gmail.com>
Cc: "Jeff Garzik" <jeff@garzik.org>,
"Maciej W. Rozycki" <macro@linux-mips.org>,
"Sébastien Dugué" <sebastien.dugue@bull.net>,
linux-kernel <linux-kernel@vger.kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Linus Torvalds" <torvalds@linux-foundation.org>
Subject: Re: commit 7e92b4fc34 - x86, serial: convert legacy COM ports to platform devices - broke my serial console
Date: Wed, 25 Jul 2007 10:11:35 -0600 [thread overview]
Message-ID: <200707251011.35891.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <86802c440707250857u22e5afa3kefb06a997c38c3b8@mail.gmail.com>
On Wednesday 25 July 2007 09:57:47 am Yinghai Lu wrote:
> On 7/25/07, Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
> > On Tuesday 24 July 2007 10:27:26 pm Yinghai Lu wrote:
> > > or we can make legacy_serial.force=1 is default at this point.
> >
> > At which point? We already do the legacy probe if there are no
> > PNP devices. Do you mean we should also do the legacy probe if
> > there are PNP devices, but no serial devices were found? That
> > might be reasonable to do, but wouldn't have prevented the problem
> > on Sebastien's machine, because his machine *does* have PNP UARTs.
>
> but still could have problem. if the system does not have any uart,
> and So we can not find that in DSDT...and we add legacy again...that
> is not right.
I'm sorry, I don't understand what you're saying.
The behavior with my patch is: If we have PNPBIOS or ACPI, and it
does not describe any UARTs, we assume the box has no UARTs. If we
don't have PNPBIOS or ACPI, we blindly probe for legacy UARTs.
What behavior are you suggesting?
Bjorn
next prev parent reply other threads:[~2007-07-25 16:23 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-24 14:28 Sébastien Dugué
2007-07-24 15:48 ` Bjorn Helgaas
2007-07-24 17:49 ` Jeff Garzik
2007-07-24 18:09 ` Andrew Morton
2007-07-24 19:07 ` Jeff Garzik
2007-07-24 18:17 ` Maciej W. Rozycki
2007-07-24 19:53 ` Bjorn Helgaas
2007-07-24 20:13 ` Jeff Garzik
2007-07-24 20:33 ` Yinghai Lu
2007-07-25 2:34 ` Bjorn Helgaas
2007-07-25 4:27 ` Yinghai Lu
2007-07-25 12:55 ` Bjorn Helgaas
2007-07-25 15:57 ` Yinghai Lu
2007-07-25 16:11 ` Bjorn Helgaas [this message]
2007-07-25 16:45 ` Yinghai Lu
2007-07-24 20:34 ` Bjorn Helgaas
2007-07-24 20:40 ` Jeff Garzik
2007-07-24 20:56 ` Bjorn Helgaas
2007-07-24 21:05 ` Jeff Garzik
2007-07-24 22:07 ` Alan Cox
[not found] ` <p73ir88sax1.fsf@bingen.suse.de>
2007-07-25 15:48 ` Alan Cox
2007-07-25 16:06 ` Bjorn Helgaas
2007-07-25 16:47 ` Jeff Garzik
2007-07-25 17:34 ` Alan Cox
2007-07-25 17:38 ` Alan Cox
2007-07-24 22:06 ` Alan Cox
2007-07-25 7:45 ` Sébastien Dugué
2007-07-25 13:16 ` Bjorn Helgaas
2007-07-25 13:32 ` Sébastien Dugué
2007-07-25 13:38 ` Sébastien Dugué
2007-07-25 22:41 ` Bjorn Helgaas
2007-07-26 0:37 ` Yinghai Lu
2007-07-26 1:35 ` Yinghai Lu
2007-07-26 2:21 ` Shaohua Li
2007-07-26 3:33 ` Bjorn Helgaas
2007-07-27 18:16 ` Bjorn Helgaas
2007-07-27 18:38 ` Yinghai Lu
2007-07-27 18:56 ` Bjorn Helgaas
2007-07-27 20:35 ` Yinghai Lu
2007-07-27 20:58 ` Bjorn Helgaas
2007-07-27 21:05 ` Jeff Garzik
2007-07-27 21:53 ` Kay Sievers
2007-07-29 17:21 ` Kyle Moffett
2007-07-29 18:03 ` Russell King
2007-07-26 8:08 ` Sébastien Dugué
2007-07-25 15:51 ` Yinghai Lu
-- strict thread matches above, loose matches on Subject: below --
2007-07-22 21:04 Linus 2.6.23-rc1 Linus Torvalds
2007-07-23 18:38 ` 2.6.23-rc1: BUG_ON in kmap_atomic_prot() Alexey Dobriyan
2007-07-23 19:01 ` Alexey Dobriyan
2007-07-23 20:24 ` Andrew Morton
2007-07-23 20:40 ` Alexey Dobriyan
2007-07-23 21:01 ` Alexey Dobriyan
2007-07-23 21:11 ` Andrew Morton
2007-07-23 21:28 ` Linus Torvalds
2007-07-24 17:59 ` Adrian Bunk
2007-07-24 18:14 ` Linus Torvalds
2007-07-26 6:09 ` commit 7e92b4fc34 - x86, serial: convert legacy COM ports to platform devices - broke my serial console H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707251011.35891.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=sebastien.dugue@bull.net \
--cc=torvalds@linux-foundation.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®